-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generator creates a project with a singe-locale #325
Merged
Merged
Changes from 20 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
2c788e5
Single locale en-US and single site RefArch
adamraya 68bffc4
Build en-US translations
adamraya 1adaba1
Set pwa-kit config url locale to none
adamraya 58b5ea7
Update create-mobify-app script wip
adamraya c4f7f89
debug create-mobify-app script
adamraya 1db75c1
Use deepmerge to add single locale data
adamraya 51c30e5
Revert test changes in the pwa
adamraya 89b88be
Set locale to none in PWAKit Config data & Fix tests
adamraya 1984967
Fix PWA Kit config json file path
adamraya bb319c9
Fix test wip
adamraya fc7a109
More fixing test wip
adamraya be721ca
Fix locale type in order test URLs
adamraya 8d73a8e
Fix locale type in account tests URLs
adamraya fffdaba
Fix more locale type in more URLs
adamraya 2ead22f
lint
adamraya 782d5ab
Refactor adding tests utils getPathname
adamraya 1c48384
lint
adamraya e0387be
Merge branch 'develop' into generator-single-site-singe-locale
adamraya 4e9f7c6
Update test use-auth-modal create an account test condition
adamraya 0073095
Update index.test.js
adamraya 060e2cf
Extract pwa-kit.config.json to assets folder
adamraya cff1447
Extract l10n config to assets folder
adamraya ffbc008
Update locale.test.js
adamraya 27383bd
Merge branch 'develop' into generator-single-site-singe-locale
adamraya 3846abd
Merge branch 'develop' into generator-single-site-singe-locale
adamraya 0b4a460
Merge branch 'develop' into generator-single-site-singe-locale
adamraya 5a9fbae
Update CHANGELOG.md
adamraya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about extracting these config-related objects into files in the folder 'packages/pwa-kit-create-app/assets/'? The ticket asks about creating files in that asset folder. It may be better to group all the files together in the same location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call! I didn't know that we added an
/assets
folder to the generator and I missed that implementation detail.Done, now the configuration objects are in files inside the assets folder.