Fix s3.get(path, { file : somePath }) not closing file on error #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #85
I used
called
variable here, because when calling destroy, it will end up callingend
event of file, which will call the call the callback again without error, but that's not what we want.I have tested this with node v0.8.25 and v0.10.13, and it passes the s3-get tests(as I mentioned, some tests fail without modifications on my system, aside those no failing tests).