Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix s3.get(path, { file : somePath }) not closing file on error #86

Open
wants to merge 1 commit into
base: future
Choose a base branch
from

Conversation

faridnsh
Copy link

Closes #85

I used called variable here, because when calling destroy, it will end up calling end event of file, which will call the call the callback again without error, but that's not what we want.

I have tested this with node v0.8.25 and v0.10.13, and it passes the s3-get tests(as I mentioned, some tests fail without modifications on my system, aside those no failing tests).

@SaltwaterC
Copy link
Owner

Hi. Sorry for replying so late. I was away from keyboard (in a place with poor to no Internet access). I'm going to merge this, but the "next" branch is the place where all the fun happens. I'm going to add a test there to see if the bug is present, but in the end, the next branch is almost a complete rewrite of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants