-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Headers field in S3 get query, to allow If-ModifiedSince #87
base: master
Are you sure you want to change the base?
Conversation
Hello, I'll "merge" this into the next brach where the development is happening. I'm dropping all the legacy code in favour of a clean start. I'm pretty close to a complete reimplementation, but I need to find some spare time to finish the S3 client and all the small features that are missing. Please send my regards to Dave. Once the next version is finished, I could use some helping hands. If you're interested in maintaining this module with yours truly, I could provide you guys access to this project. You're one of the most active people around, anyway. Thanks, |
Thanks Stefan - look forward to it. Happy to stay involved - let me know if there's anything you'd like me to Regards cc'd to Dave, and (I'm sure) reciprocated. Best David On Tue, Mar 11, 2014 at 9:51 AM, Ștefan Rusu notifications@gh.neting.ccwrote:
David Harvey |
Hi all: quick question from me, I see that Amazon started their own NodeJS
On Tue, Mar 11, 2014 at 10:54 AM, David Harvey dth@vyclone.com wrote:
|
Hi Stefan
We needed to get S3 files only if changed since the timestamp of a local copy, so I've forked and implemented a small change which allows a 'headers' field in the S3 GET query, to let us do:
Please let me know if you're happy with this, or if you'd like to allow this via another means.
(best regards from my colleague Dave Cleal, by the way...)
(Oh, and a while back Dave issued a pull request which inadvertently included some CloudFront work I'd done. We're just about to use this, so I'll reinstate and get another pull request in shortly...)
Thanks
David Harvey