Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNF command for Linux updates #28

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

x1101
Copy link
Contributor

@x1101 x1101 commented Oct 25, 2024

Pull Request

Issue

N/A

Description

Adding "dnf" update command for other versions of Linux

License

By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.

@x1101
Copy link
Contributor Author

x1101 commented Oct 25, 2024

@SamErde I'm unsure what these failures mean. Any thoughts on how to clean them up (or, if they need cleaned up) before this minor change is good for merge?

@SamErde
Copy link
Owner

SamErde commented Oct 25, 2024

I'll have to review those, but in the meantime, can you actually commit these changes to the module's source file at https://github.com/SamErde/PSPreworkout/blob/main/src/PSPreworkout/Public/Update-AllTheThings.ps1?

The version in the scripts folder is built separately from the source and adds additional metadata so it can be published as a standalone script to the PowerShell Gallery.

Thanks!

@x1101
Copy link
Contributor Author

x1101 commented Oct 25, 2024

Does the change need to be in both files, or will the one I modified pick it up from the one you noted?

@SamErde
Copy link
Owner

SamErde commented Oct 25, 2024

Just the one under /src is fine.

If you look in the /Scripts folder, you'll see that I have a specific build script for that copy. 🤓

@SamErde SamErde merged commit f06d805 into SamErde:main Oct 25, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants