Fix tests #117
Merged
Fix tests #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115.
Tests are currently failing (see #116, for example), suggesting that there are one less object allocated than we expect, because of some changes in minitest recently.
Previously, this line
memory_profiler/test/test_reporter.rb
Line 15 in cd6fa67
*argsand aThread::Mutexinstance):minitest/minitest@5f5c211#diff-b43f1192f616004aa819abdb67ebe90528572c49ec805b9ad66ce45e1afce97bL622
https://github.com/ruby/mutex_m/blob/86ee14345740636a909b54f089f7eb0d51ea134f/lib/mutex_m.rb#L116-L119
But after the changes, only the mutex now: minitest/minitest@5f5c211#diff-b43f1192f616004aa819abdb67ebe90528572c49ec805b9ad66ce45e1afce97bR621-R623