-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for top-level await #9
Conversation
@sindresorhus @SamVerschueren |
Can you explain your changes? Why are you now bundling the |
I don't see why these changes would make it support top level await all of a sudden? It has to do with the underlying Node version that's being used I assume? Unless Alfred is using one of these environment variables sindresorhus/run-node@9a69ce7, I don't see how these changes would actually make it work? |
Alfy have support top level await. There always run it, and isee the pr for alfy how add top level await, and got this script, so i copy it. because i don't think change the run-node is a good idea. |
Anything? |
So the thing here is that @sindresorhus would it make sense to create a new |
I would just copy-paste it here for now. Node.js will eventually support top-level await by default. We can open an issue to revert back to |
Anything? |
Did this project alive? |
Sorry, totally missed that you updated your PR. I'll com back to you later today. |
I know that you guys too busy, so don't be sorry. Anyway, thank you for you guys make this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment.
This change is a bit controversial to me. When having both The So if I want to run in plain node without esm then this change breaks things for me. I have to either install |
We might want to keep this in line with the Alfy moved to ESM entirely in August and thus got rid of the |
I guess that would entitle switching this package to be an ES module itself? So a breaking change. |
This package not support top level await before, but alfy support.