Recognise RxObservable.of
and others
#77
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Sam
I found that although Listr claims that it supports RxObservable but in fact, it only recognises the plainest RxObervable comes from
new Observable()
. NeitherRxObservable.of()
norRxObservable.combineLatest()
and more will be recognised.I add the instance check base on this SO answer. https://stackoverflow.com/a/41452513/1016407
Please let me know if there is any problem and please kindly accept the PR.