Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognise RxObservable.of and others #77

Conversation

jonakyd
Copy link

@jonakyd jonakyd commented Sep 25, 2017

Hi, Sam
I found that although Listr claims that it supports RxObservable but in fact, it only recognises the plainest RxObervable comes from new Observable(). Neither RxObservable.of() nor RxObservable.combineLatest() and more will be recognised.

I add the instance check base on this SO answer. https://stackoverflow.com/a/41452513/1016407

Please let me know if there is any problem and please kindly accept the PR.

@SamVerschueren
Copy link
Owner

It seems that the issue, which is linked in the code (sindresorhus/is-observable#1), was resolved. I'm looking into it wheter it's really the case, but if it is, we could use is-observable again. I tested Observable.of with is-observable and it works fine.

So hold on a brief moment until I'm sure that the issue was resolved. Thanks for the PR!

@jonakyd
Copy link
Author

jonakyd commented Sep 25, 2017

Thank you. Please let me know if there is anything I can help.

@SamVerschueren
Copy link
Owner

If it's possible to test your code in the meantime by using is-observable, that would be great :).

@SamVerschueren
Copy link
Owner

I just added is-observable to detect Observables. I'm releasing the next version today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants