Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add error code sensor #18

Merged
merged 8 commits into from
Apr 2, 2024
Merged

feat: Add error code sensor #18

merged 8 commits into from
Apr 2, 2024
+71 −13

Commits on Apr 1, 2024

  1. feat: Add error code conversions

    @KazWolfe
    KazWolfe committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    abdcee4 View commit details
    Browse the repository at this point in the history

  2. feat: Request error information if no MHK2 is detected

    @KazWolfe
    KazWolfe committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    7b38e9a View commit details
    Browse the repository at this point in the history

  3. fix: Change test for detecting thermostat for error checks

    @KazWolfe
    KazWolfe committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    aeb5e1f View commit details
    Browse the repository at this point in the history

  4. feat: Add Error Sensor

    @KazWolfe
    KazWolfe committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    a5a0036 View commit details
    Browse the repository at this point in the history

  5. chore: Add in log validation for a bad error packet 

    - Has no actual impact on anything, but good to know.
    @KazWolfe
    KazWolfe committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    a0063bc View commit details
    Browse the repository at this point in the history

  6. fix: Prevent possible UB caused by integer overflow 

    While the loop counter overflowing shouldn't cause any particular problems, it's still probably best to just not let it overflow in the first place.

10,000 cycles should be enough for *any* scheduled event until there's a better system for infrequent events.
    @KazWolfe
    KazWolfe committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    acbfd01 View commit details
    Browse the repository at this point in the history

  7. fix: Code Review Comments 

    - Remove identified `auto` typing.
- Simplify error packet else case to not care about logic flaws.
- Check `raw_state` for publish checks, as that's what we're actually setting.
    @KazWolfe
    KazWolfe committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    b89e0e1 View commit details
    Browse the repository at this point in the history

  8. fix: More aggressive error checking 

    - Remove code to only check errors if the MHK isn't sending those packets.
- Remove the every-n-ticks system.
- Add TODO just in case this does cause issues later.
    @KazWolfe
    KazWolfe committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    b1f66f7 View commit details
    Browse the repository at this point in the history