Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cute objects in cute bomb no longer repeat #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cute objects in cute bomb no longer repeat #10

wants to merge 1 commit into from

Conversation

hoppermeister
Copy link
Collaborator

No description provided.

lhigginbotham
lhigginbotham reviewed Feb 20, 2017
View reviewed changes
Copy link

@lhigginbotham lhigginbotham left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now with technically less random! I'm afraid I can't support this PR 👎

SammyIsra
SammyIsra requested changes Feb 21, 2017
View reviewed changes
Copy link
Owner

@SammyIsra SammyIsra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this prevent cute bombs to have repeated links? Also, can you prevent super huge bombs? Ideally, no one would get a 20+ bomb.

SammyIsra
SammyIsra requested changes Feb 21, 2017
View reviewed changes
Copy link
Owner

@SammyIsra SammyIsra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, since we have a limit of 10k history on Slack, can you aggregate all links into a single message and send it once? Instead of sending one message per ink.

@hoppermeister
Copy link
Collaborator Author

Super late but no- putting all of the links in one message would only have one thumbnail, ruining the point of the 'bomb'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhigginbotham lhigginbotham lhigginbotham left review comments

@SammyIsra SammyIsra SammyIsra requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoppermeister @lhigginbotham @SammyIsra