Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web 6 contributors section update #31

Merged
merged 8 commits into from
Feb 7, 2024
Merged

Conversation

renaldox
Copy link
Collaborator

@renaldox renaldox commented Feb 4, 2024

Describe your changes

updating branch with all changes

Issue ticket number and link

Issue #19

Checklist before requesting a review

  • [x ] I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Will this be part of a product update? If yes, please write one phrase about this update.

Copy link

netlify bot commented Feb 4, 2024

Deploy Preview for samoa-stack-overflow ready!

Name Link
🔨 Latest commit 2c8edc2
🔍 Latest deploy log https://app.netlify.com/sites/samoa-stack-overflow/deploys/65c3442bd36c82000876e20b
😎 Deploy Preview https://deploy-preview-31--samoa-stack-overflow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@westerandr
Copy link
Contributor

Uso can you pull latest changes from main please? and include your component with the rest in page.svelte

@westerandr
Copy link
Contributor

But overall looks good! Might need you to work on different colors for dark and light mode for the cards. Looks good on mobile, might need to reduce space between cards. Good stuff!

@Green-Ranger11
Copy link
Contributor

Also don't forget to import and showcase your changes in the +page.svelte file!

@westerandr
Copy link
Contributor

Also don't forget to reference the issue number in your PR description.

Copy link
Contributor

@Green-Ranger11 Green-Ranger11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change and should be good to go!

src/lib/Components/Contributors.svelte Outdated Show resolved Hide resolved
src/lib/Components/Contributors.svelte Outdated Show resolved Hide resolved
src/lib/Components/Contributors.svelte Outdated Show resolved Hide resolved
Copy link
Contributor

@Green-Ranger11 Green-Ranger11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change and should be good to go!

Copy link
Contributor

@Green-Ranger11 Green-Ranger11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Malo lava!

@Green-Ranger11 Green-Ranger11 merged commit 2c8edc2 into main Feb 7, 2024
4 checks passed
@Green-Ranger11 Green-Ranger11 deleted the WEB-6-Contributors-Section branch February 7, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants