Fix wpm #22
Merged
Fix wpm #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #21 see issue for the reasoning, etc. number of correctly typed chars and number of uncorrected errors is calculated after the typing has completed. ToipeResults: - changed field names - documented fields - added final_chars_typed_correctly and final_uncorrected_errors fields - CPM is not available anymore - WPM is calculated using a fixed 5 chars per word instead of calculating it on the fly - uncorrected errors are penalized - value is clamped to 0.0 to prevent negative WPM - `num_correct_chars()` did not make sense to keep as a function since it's only used in accuracy - note: accuracy calculation has not changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21
See commit messages for details