Save Results #43
Open
Save Results #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes std::time in favor of chrono because chrono has built-in support for serde via the "serde" features flag.
|
Thank you for this @treatybreaker. I haven't been able to find time to review this PR thoroughly, it will take some more time. Some thoughts though:
|
Samyak2
requested changes
Oct 21, 2022
Comment on lines
+95
to
+101
| if config.results_file.is_none() { | ||
| config.results_file = match std::env::var("TOIPE_RESULTS_FILE") { | ||
| Ok(results_file_env) => Some(results_file_env), | ||
| Err(_) => None, | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
clap supports reading a configuration value from an environment variable. See env under https://docs.rs/clap/latest/clap/_derive/index.html#arg-attributes. Could you add that to the ToipeConfig struct and remove this code from here?
There was a problem hiding this comment.
I can take a look and get those changes in. I'm pretty busy myself as it stands, so I likely won't be able to get around to it until this coming weekend. Only saw this now due to my inbox refreshing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes issue #11.
Summary
This PR adds the ability to save results to a file via the
-rflag. In the current implementation results are not saved by default, instead the user must pass either the new-rflag and a path or set theTOIPE_RESULTS_FILEenvironment variable to a file path.Notes
The only thing that we might want to modify is the error type being returned by the
save_resultsfunction I've added. I do not useToipeErrorand instead fall back onstd::io::Errorwhich gets unrolled up where it is then turned intoToipeError, but in doing so the error information is dropped. See here for thesave_resultsfunction and here for how I'm taking the error in and returningToipeError.Let me know what suggestions you have and I'll be happy to make any relevant modifications. I'm not the biggest Rust guy, so I may have missed more idiomatic patterns that would improve this PR.