Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a small mistake in the parameter naming #987

Merged
merged 1 commit into from
May 24, 2023
Merged

a small mistake in the parameter naming #987

merged 1 commit into from
May 24, 2023

Conversation

kagetu
Copy link
Contributor

@kagetu kagetu commented May 23, 2023

I used some features of flecs in my program, and I noticed a small mistake in the parameter naming. as follows:
#define flecs_hashmap_init(hm, K, V, compare, hash, allocator)\ _flecs_hashmap_init(hm, ECS_SIZEOF(K), ECS_SIZEOF(V), compare, hash, allocator)

#define flecs_hashmap_init(hm, K, V, hash, compare, allocator)\ _flecs_hashmap_init(hm, ECS_SIZEOF(K), ECS_SIZEOF(V), hash, compare, allocator)

I used some features of flecs in my program, and I noticed a small mistake in the parameter naming. as follows:
-  #define flecs_hashmap_init(hm, K, V, compare, hash, allocator)\
    _flecs_hashmap_init(hm, ECS_SIZEOF(K), ECS_SIZEOF(V), compare, hash, allocator)

+ #define flecs_hashmap_init(hm, K, V, hash, compare, allocator)\
    _flecs_hashmap_init(hm, ECS_SIZEOF(K), ECS_SIZEOF(V), hash, compare, allocator)
@SanderMertens
Copy link
Owner

Nice catch! Thanks for the PR :)

@SanderMertens SanderMertens merged commit 2f1a32f into SanderMertens:master May 24, 2023
@kagetu kagetu deleted the kagetu-patch-1 branch June 12, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants