Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining issues:
flecs/src/addons/os_api_impl/windows_impl.inl:46:33: warning: incompatible pointer types passing 'int32_t *' (aka 'int *') to parameter of type 'volatile long *' [-Wincompatible-pointer-types]
flecs/src/addons/os_api_impl/windows_impl.inl:53:33: warning: incompatible pointer types passing 'int32_t *' (aka 'int *') to parameter of type 'volatile long *' [-Wincompatible-pointer-types]
flecs/src/addons/os_api_impl/windows_impl.inl:230:28: warning: implicit conversion from 'LONGLONG' (aka 'long long') to 'double' may lose precision [-Wimplicit-int-float-conversion]
flecs/src/addons/http.c:341:30: warning: implicit conversion changes signedness: 'uint32_t' (aka 'unsigned int') to 'socklen_t' (aka 'int') [-Wsign-conversion]
flecs/src/addons/http.c:352:29: warning: implicit conversion changes signedness: 'uint32_t' (aka 'unsigned int') to 'int' [-Wsign-conversion]
flecs/src/addons/http.c:1144:22: warning: comparison of integers of different signs: 'int' and 'SOCKET' (aka 'unsigned long long') [-Wsign-compare]