Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Collapse button for filters #58 #62

Conversation

dangvu0502
Copy link
Contributor

Instead of adding new button, I add ability to collapse filters when user click search box.

@Sanix-Darker
Copy link
Owner

Thanks for this Pull Request !
It's Huge 😅 !
Looks like there is a lot of code formating !

  • Is it possible to split those commits ? (one for the formating, one for the collapse feature and the last one for the yarn lock).
  • And a small gif preview of what you did in the Pull Request description ? 🙏🏾 (i didn't setUp a deployment workflow for each new pull request, but i keep that in mind !)

@dangvu0502
Copy link
Contributor Author

Oh, silly me!!
I add all changes to commit without checking redundants (almost is formatting on save and yarn lock autogenerated).
Now It's difficult to split those changes. Should I create new pull request?
I do not know how to create a gif so i will give you video instead.

Zzollo-Search-Engine.App.-.Google.Chrome.2022-08-16.16-18-03.mp4

@Sanix-Darker
Copy link
Owner

In a new Pull Request if possible yes, or reset the commit on this PR and push force new ones !
As you wish !
Thanks for the preview, looks awesome 🔥 !

@dangvu0502 dangvu0502 force-pushed the enhancement/add-collapsible-filters branch from 8861625 to b1b391f Compare August 16, 2022 09:53
@dangvu0502
Copy link
Contributor Author

I have updated these changes.
Forgive my dummy mistake on committing.

@Sanix-Darker
Copy link
Owner

Thanks for your changes !
Looks Good to me !

Forgive my dummy mistake on committing.

Don't worry mate, it's okay 😃 !

@Sanix-Darker Sanix-Darker merged commit fc32bdc into Sanix-Darker:master Aug 16, 2022
This was referenced Aug 16, 2022
@Sanix-Darker Sanix-Darker mentioned this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants