Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pester v5 #26

Merged
merged 4 commits into from
May 29, 2024
Merged

Pester v5 #26

merged 4 commits into from
May 29, 2024

Conversation

Sarafian
Copy link
Owner

No description provided.

@AppVeyorBot
Copy link

@belibug
Copy link
Contributor

belibug commented May 29, 2024

It seems like @Sarafian have already worked on PesterV5 adaption a bit, any reason why this was not merged.

Should I continue from here or simply start over from master branch to migrate tests to Pester5.

I find it easy to start over. This branch will help me understand your style and approach (dont remove it yet please)

@Sarafian
Copy link
Owner Author

Sarafian commented May 29, 2024

@belibug honestly I don't remember. Keep in mind there is #27 with small minor bug fix that is blocked because of this.
If this works and the appveyor ci works, then this and #27 are both good.

From little I remember, I hadn't checked if the adaptation to pester v5 was the correct one. I just had modified the code as they suggested. But I use extensive mocks etc and there is bad history.

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@Sarafian Sarafian merged commit cf2ea24 into master May 29, 2024
2 checks passed
@Sarafian Sarafian deleted the pester-v5 branch May 29, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants