Skip to content

Commit

Permalink
add README and LICENSE for run-clang-tidy.py
Browse files Browse the repository at this point in the history
This should give more proper attribution to the script origin.

See discussion:
- #443
  • Loading branch information
Sarcasm committed Oct 18, 2017
1 parent a571167 commit 78b06aa
Show file tree
Hide file tree
Showing 4 changed files with 56 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ matrix:
- make -k
- make check
- |
../server/run-clang-tidy.py \
../server/build-aux/run-clang-tidy/run-clang-tidy.py \
-clang-tidy-binary clang-tidy-4.0 \
-clang-apply-replacements-binary clang-apply-replacements-4.0 \
-p . \
Expand Down
43 changes: 43 additions & 0 deletions server/build-aux/run-clang-tidy/LICENSE.TXT
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
==============================================================================
LLVM Release License
==============================================================================
University of Illinois/NCSA
Open Source License

Copyright (c) 2007-2016 University of Illinois at Urbana-Champaign.
All rights reserved.

Developed by:

LLVM Team

University of Illinois at Urbana-Champaign

http://llvm.org

Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal with
the Software without restriction, including without limitation the rights to
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
of the Software, and to permit persons to whom the Software is furnished to do
so, subject to the following conditions:

* Redistributions of source code must retain the above copyright notice,
this list of conditions and the following disclaimers.

* Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimers in the
documentation and/or other materials provided with the distribution.

* Neither the names of the LLVM Team, University of Illinois at
Urbana-Champaign, nor the names of its contributors may be used to
endorse or promote products derived from this Software without specific
prior written permission.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
CONTRIBUTORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS WITH THE
SOFTWARE.
12 changes: 12 additions & 0 deletions server/build-aux/run-clang-tidy/README
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
Origin:
- http://llvm.org/svn/llvm-project/clang-tools-extra/trunk/clang-tidy/tool/run-clang-tidy.py?p=294607
- https://github.com/llvm-mirror/clang-tools-extra/blob/c2e903ec98385b82e35bdb303e411854a2e8c032/clang-tidy/tool/run-clang-tidy.py

Modifications:
- the python version has been frozen to python2,
as the script is not python3-compatible
- added -warnings-as-errors option
- the run-clang-tidy.py script has been modified
to return a sensible exit code when running on Travis CI,
i.e. it honors exit code of the underlying processes
causing build failures on pull requests
File renamed without changes.

5 comments on commit 78b06aa

@sten0
Copy link
Contributor

@sten0 sten0 commented on 78b06aa Oct 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I not clear on how LLVM licensing works, eg: if University of Illinois at Urbana-Champaign is the sole copyright holder, but I suspect a copy of CODE_OWNERS.TXT should also be included, because it attributes run-clang-tidy.py to Alexander Kornienko. Here is a link to a copy @c2e903ec98385b82e35bdb303e411854a2e8c032 from when run-clang-tidy.py was forked:

https://github.com/llvm-mirror/clang-tools-extra/blob/c2e903ec98385b82e35bdb303e411854a2e8c032/CODE_OWNERS.TXT

@Sarcasm
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this file means what you think.
Reading the description here:

And the concept seems similar on Github:

This file seems to be more about code review, who is responsible for the reviews when a file is modified in the tree.
In the case of irony-mode, if someone happens to be modifying my version of run-clang-tidy.py,
then I don't think the reviewers should be the LLVM folks, it should be me.

One thing I wondered however, is if I have to mention the Copyright somewhere else than in the file.

@sten0
Copy link
Contributor

@sten0 sten0 commented on 78b06aa Oct 19, 2017 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sarcasm
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, would you please tag a patch level release when this work is
done, because this commit moves files?

I have made a new release:

@sten0
Copy link
Contributor

@sten0 sten0 commented on 78b06aa Oct 21, 2017 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.