Revert change to Irony mode to patch a now fixed bug in Clang that has not existed since about version 9 #569
Conversation
…ved classes. i.e. their availability is accessible.
…is no longer a need for it
|
See #369 |
| @@ -234,10 +221,6 @@ displayed when a derived class overrides virtual methods." | |||
| (defun irony-completion-post-comp-placeholders (candidate) | |||
| (cdr (nth 6 candidate))) | |||
|
|
|||
| (defun irony-completion-availability (candidate) | |||
There was a problem hiding this comment.
This has been removed, but it's still used by irony-completion--filter-candidates below.
irony-completion.el
Outdated
| (irony--run-task | ||
| (irony--candidates-task nil (car it) prefix style))))) | ||
| Example: (\"(int a, int b)\" 1 6 8 13)" | ||
| (and (irony-completion-candidates-available-p) |
There was a problem hiding this comment.
Is this code correct?
Looks like it's not only the documentation that changed, but the implementation too, the function is no longer running a task so I'm a bit surprised.
|
Although the commit is named "bad1285", I think it's a nice addition. 😀 |
|
I definitely think we should revert the commit. I was not happy with it. The fact is I will never get my head around git. I have been an svn user for years and I just cannot get used to this thing. So I was making local changes on my local machine due to your review comments. Then I pushed the changes not realising they would show up here and that you would get updated. I think what you have done is trusted my changes too much. I have not even tested thi which I plan on doing. And I was relying on the automatic tests that normally used to run when I made a pull request. Are you actually happy and have you tested irony-nodebas it is with this latest commit because I fear that git is trying to tell us something with "bad" in the ID. Thanks. |
|
Oh, I thought you tested it locally before creating a pull request. I'm okay to revert, but what are you afraid off to be broken? Before I revert, you can maybe test it a bit, and see if completion isn't broken, and that inaccessible (private?) fields aren't offered. |
|
Hi @Sarcasm, Let me do some testing and I'll update you later. At the latest on Sunday night. If you hear nothing then you should revert and I will perform another pull request from fresh. If it works then I will let you know. Sorry, I should have tested locally before and never realised that git push would update you. Let's talk soon. |
I finally have got around to removing the fix introduced to irony to display non-accessibles. Recall that before version 9 of LLVM/Clang (or around that time) protected members/methods were not showing in derived classes in completions due to a bug in LLVM/Clang.