Adds comparison ALL bar for HIV Black Women #3665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity-tracker into black-men-homicides
✅ Deploy Preview for health-equity-tracker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
kccrtv
requested changes
Sep 13, 2024
There was a problem hiding this comment.
`Ages 13+` is truncating at the laptop view and below. can you break up the span into two, so that "(All People," is on the top and "Ages 13+)" is on the bottom?
additionally, could you add a note here in the definitions, and/or even on the horizontal card on what our definition of "All People" is? like we're including NH and H, as well as including Black Women, in this average? it is a bit unclear.
Removes parentheses, adds 3rd line to keep from truncating long text, adds footnote indicating when ALL PEOPLE means 
|
kccrtv
pushed a commit
to kccrtv/health-equity-tracker
that referenced
this pull request
Sep 16, 2024
# Description and Motivation <!--- bulleted, high level items. use keywords (eg "closes SatcherInstitute#144" or "fixes #4323") --> - adds HIV Black Women for SatcherInstitute#3627 by updating the MetriccConfig - allow any subpopAge to pass through to the comparison All Bar, for example all Black Women HIV topics and their gen. pop. equivalent use ages 13+ ## Has this been tested? How? passing ## Screenshots (if appropriate) <img width="1194" alt="Screenshot 2024-09-12 at 8 32 51 PM" src="https://github.com/user-attachments/assets/3d8e146f-1ac3-424e-9136-4c75b361ea10"> <img width="1194" alt="Screenshot 2024-09-12 at 8 33 07 PM" src="https://github.com/user-attachments/assets/e8776720-16b9-47aa-829a-44c52a6e070c"> <img width="1194" alt="Screenshot 2024-09-12 at 8 33 17 PM" src="https://github.com/user-attachments/assets/9467b37d-bb30-4f73-885b-cbddbb08b011"> ## Types of changes (leave all that apply) - New content or feature ## New frontend preview link is below in the Netlify comment 😎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
Has this been tested? How?
passing
Screenshots (if appropriate)
Types of changes
(leave all that apply)
New frontend preview link is below in the Netlify comment 😎