Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds comparison ALL bar for HIV Black Women #3665

Merged

Conversation

benhammondmusic
Copy link
Collaborator

@benhammondmusic benhammondmusic commented Sep 13, 2024

Description and Motivation

Has this been tested? How?

passing

Screenshots (if appropriate)

Screenshot 2024-09-12 at 8 32 51 PM Screenshot 2024-09-12 at 8 33 07 PM Screenshot 2024-09-12 at 8 33 17 PM

Types of changes

(leave all that apply)

  • New content or feature

New frontend preview link is below in the Netlify comment 😎

Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for health-equity-tracker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 29899c6
🔍 Latest deploy log https://app.netlify.com/sites/health-equity-tracker/deploys/66e4968c337e7e000813fd9b
😎 Deploy Preview https://deploy-preview-3665--health-equity-tracker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@benhammondmusic benhammondmusic marked this pull request as ready for review September 13, 2024 17:29
Copy link
Collaborator

@kccrtv kccrtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-09-13 at 12 25 58 PM `Ages 13+` is truncating at the laptop view and below. can you break up the span into two, so that "(All People," is on the top and "Ages 13+)" is on the bottom?
additionally, could you add a note here in the definitions, and/or even on the horizontal card on what our definition of "All People" is? like we're including NH and H, as well as including Black Women, in this average? it is a bit unclear.
Screenshot 2024-09-13 at 12 38 35 PM

@benhammondmusic
Copy link
Collaborator Author

Screenshot 2024-09-13 at 12 25 58 PM Ages 13+ is truncating at the laptop view and below. can you break up the span into two, so that "(All People," is on the top and "Ages 13+)" is on the bottom?
additionally, could you add a note here in the definitions, and/or even on the horizontal card on what our definition of "All People" is? like we're including NH and H, as well as including Black Women, in this average? it is a bit unclear.
Screenshot 2024-09-13 at 12 38 35 PM

Removes parentheses, adds 3rd line to keep from truncating long text, adds footnote indicating when ALL PEOPLE means

Screenshot 2024-09-13 at 1 43 22 PM Screenshot 2024-09-13 at 1 43 36 PM

Copy link
Collaborator

@kccrtv kccrtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks Ben!

@benhammondmusic benhammondmusic merged commit 8df3fcd into SatcherInstitute:main Sep 13, 2024
10 checks passed
@benhammondmusic benhammondmusic deleted the black-women-hiv-all-bar branch September 13, 2024 20:41
kccrtv pushed a commit to kccrtv/health-equity-tracker that referenced this pull request Sep 16, 2024
# Description and Motivation
<!--- bulleted, high level items. use keywords (eg "closes SatcherInstitute#144" or
"fixes #4323") -->

- adds HIV Black Women for SatcherInstitute#3627 by updating the MetriccConfig
- allow any subpopAge to pass through to the comparison All Bar, for
example all Black Women HIV topics and their gen. pop. equivalent use
ages 13+

## Has this been tested? How?

passing

## Screenshots (if appropriate)

<img width="1194" alt="Screenshot 2024-09-12 at 8 32 51 PM"
src="https://github.com/user-attachments/assets/3d8e146f-1ac3-424e-9136-4c75b361ea10">
<img width="1194" alt="Screenshot 2024-09-12 at 8 33 07 PM"
src="https://github.com/user-attachments/assets/e8776720-16b9-47aa-829a-44c52a6e070c">
<img width="1194" alt="Screenshot 2024-09-12 at 8 33 17 PM"
src="https://github.com/user-attachments/assets/9467b37d-bb30-4f73-885b-cbddbb08b011">


## Types of changes

(leave all that apply)

- New content or feature

## New frontend preview link is below in the Netlify comment 😎
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants