Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error-msg class in ValidationErrors for settings #1064

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Add error-msg class in ValidationErrors for settings #1064

merged 1 commit into from
Dec 7, 2023

Conversation

Gauravtalreja1
Copy link
Collaborator

No description provided.

@Gauravtalreja1
Add error-msg class in ValidationErrors for settings
6dde5e9 
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
@Gauravtalreja1 Gauravtalreja1 added 6.12.z CherryPick PR needs CherryPick to previous branches 6.13.z AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing 6.14.z 6.15.z labels Dec 7, 2023
@Gauravtalreja1 Gauravtalreja1 self-assigned this Dec 7, 2023
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_settings.py::test_negative_update_hostname_with_empty_fact

@Gauravtalreja1 Gauravtalreja1 mentioned this pull request Dec 7, 2023
Merged
LadislavVasina1
LadislavVasina1 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@LadislavVasina1 LadislavVasina1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

This was referenced Dec 7, 2023
Merged
Merged
Merged
Merged
shubhamsg199
shubhamsg199 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@shubhamsg199 shubhamsg199 merged commit bf3fe5d into SatelliteQE:master Dec 7, 2023
14 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 7, 2023
@Gauravtalreja1 @web-flow
Add error-msg class in ValidationErrors for settings (#1064)
14e65af 
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit bf3fe5d)
github-actions bot pushed a commit that referenced this pull request Dec 7, 2023
@Gauravtalreja1 @web-flow
Add error-msg class in ValidationErrors for settings (#1064)
8563eab 
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit bf3fe5d)
This was referenced Dec 7, 2023
Merged
Merged
github-actions bot pushed a commit that referenced this pull request Dec 7, 2023
@Gauravtalreja1 @web-flow
Add error-msg class in ValidationErrors for settings (#1064)
74f4c63 
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit bf3fe5d)
This was referenced Dec 7, 2023
Merged
Merged
github-actions bot pushed a commit that referenced this pull request Dec 7, 2023
@Gauravtalreja1 @web-flow
Add error-msg class in ValidationErrors for settings (#1064)
afcca95 
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit bf3fe5d)
shubhamsg199 pushed a commit that referenced this pull request Dec 7, 2023
@Satellite-QE @Gauravtalreja1
Add error-msg class in ValidationErrors for settings (#1064) (#1068)
cb0b85c 
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit bf3fe5d)

Co-authored-by: Gaurav Talreja <gtalreja@redhat.com>
shubhamsg199 pushed a commit that referenced this pull request Dec 7, 2023
@Satellite-QE @Gauravtalreja1
Add error-msg class in ValidationErrors for settings (#1064) (#1067)
e7da32e 
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit bf3fe5d)

Co-authored-by: Gaurav Talreja <gtalreja@redhat.com>
shubhamsg199 pushed a commit that referenced this pull request Dec 7, 2023
@Satellite-QE @Gauravtalreja1
Add error-msg class in ValidationErrors for settings (#1064) (#1066)
cbe89d6 
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit bf3fe5d)

Co-authored-by: Gaurav Talreja <gtalreja@redhat.com>
shubhamsg199 pushed a commit that referenced this pull request Dec 7, 2023
@Satellite-QE @Gauravtalreja1
Add error-msg class in ValidationErrors for settings (#1064) (#1065)
ec5fa21 
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit bf3fe5d)

Co-authored-by: Gaurav Talreja <gtalreja@redhat.com>
damoore044 pushed a commit to damoore044/airgun that referenced this pull request Jan 12, 2024
@Gauravtalreja1 @damoore044
Add error-msg class in ValidationErrors for settings (SatelliteQE#1064)
c8a141c 
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.12.z 6.13.z 6.14.z 6.15.z AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gauravtalreja1 @LadislavVasina1 @shubhamsg199