Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.14.z] Remove codecov #1130

Merged
merged 1 commit into from
Apr 9, 2024
Merged

[6.14.z] Remove codecov #1130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .codecov.yml
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions .github/workflows/merge_to_master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,6 @@ jobs:
- name: Pre Commit Checks
uses: pre-commit/action@v3.0.0

- name: Test Nailgun Coverage
run: |
make test-coverage

- name: Make Docs
run: |
make docs-html
Expand All @@ -60,11 +56,6 @@ jobs:
if: failure()
run: git diff

- name: Upload Codecov Coverage
uses: codecov/codecov-action@v1.0.13
with:
fail_ci_if_error: true

build-n-publish:
name: Build and publish Python 🐍 distributions 📦 to PyPI
runs-on: ubuntu-latest
Expand Down
9 changes: 2 additions & 7 deletions .github/workflows/pull_requests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,8 @@ jobs:
pip install --compile --no-cache-dir pycurl
pip install -U -r requirements.txt -r requirements-dev.txt --no-cache-dir

- name: Test Nailgun Coverage
run: |
make test-coverage
- name: Run Tests
run: make test

- name: Make Docs
run: |
Expand All @@ -56,7 +55,3 @@ jobs:
if: failure()
run: git diff

- name: Upload Codecov Coverage
uses: codecov/codecov-action@v1.0.13
with:
fail_ci_if_error: true
6 changes: 1 addition & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ help:
@echo "Please use \`make <target>' where <target> is one of:"
@echo " help to show this message"
@echo " test to run unit tests"
@echo " test-coverage to run unit tests and measure test coverage"
@echo " docs-html to generate HTML documentation"
@echo " docs-clean to remove documentation"
@echo " package to generate installable Python packages"
Expand All @@ -21,9 +20,6 @@ docs-clean:
test:
python $(TEST_OPTIONS)

test-coverage:
coverage run --source nailgun $(TEST_OPTIONS)

package:
./setup.py sdist bdist_wheel --universal

Expand All @@ -33,4 +29,4 @@ package-clean:
publish: package
twine upload dist/*

.PHONY: help docs-html docs-clean test test-coverage package package-clean publish
.PHONY: help docs-html docs-clean test package package-clean publish
3 changes: 0 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,3 @@ combine-as-imports = true
[tool.ruff.mccabe]
max-complexity = 25

[tool.coverage.run]
omit = ["tests/*"]
include = ["nailgun/*.py"]
4 changes: 0 additions & 4 deletions requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,5 @@ wheel
# For `make publish`
twine

# For code coverage
codecov==2.1.13
coverage[toml]

# For linting
ruff
Loading