Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15.z] Use server_config as named argument only #1161

Merged

Conversation

Satellite-QE
Copy link
Contributor

Cherrypick of PR: #1152

Description of changes

Update all entity initialization calls to pass server_config as a named kwarg instead of as a positional arg.

Fixes #1038

pytest_fixtures/component/taxonomy.py:43: in module_org
    return module_target_sat.api.Organization().create()
../../lib64/python3.12/site-packages/nailgun/entities.py:5803: in create
    return type(self)(
E   TypeError: Organization.__init__() got multiple values for argument 'server_config'
Functional demonstration

nailgun tests:

# make test
python -m unittest discover --start-directory tests --top-level-directory .
................................................................................................................................................................................................................................................................................
----------------------------------------------------------------------
Ran 272 tests in 5.584s

OK

robottelo tests:

$ pytest tests/foreman/api/test_organization.py 
[...]
tests/foreman/api/test_organization.py ...........................................     [100%]
=== 43 passed, 175 warnings in 215.71s (0:03:35) ===

robottelo PRT:
job/robottelo-pr-testing/7142/console:

10:45:45  ================= 43 passed, 237 warnings in 812.40s (0:13:32) =================
Additional Information

@Satellite-QE Satellite-QE self-assigned this May 28, 2024
@tpapaioa tpapaioa added No-CherryPick PR doesnt need CherryPick to previous branches Auto_Cherry_Picked GHA has automatically cherrypicked this PR 6.15.z labels May 28, 2024
@tpapaioa tpapaioa merged commit e69cfbe into 6.15.z May 28, 2024
16 of 17 checks passed
@tpapaioa tpapaioa deleted the cherry-pick-6.15.z-480e4c1e0ca51a88c8925c87c5c257f5ed46ebde branch May 28, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants