Fix for registration command packages #1225
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosas
added
CherryPick
|
Can one of the admins verify this patch? |
| @@ -6792,7 +6792,7 @@ def __init__(self, server_config=None, **kwargs): | |||
| 'jwt_expiration': entity_fields.IntegerField(default=4), | |||
| 'repo': entity_fields.StringField(default=''), | |||
| 'repo_gpg_key_url': entity_fields.URLField(default=''), | |||
| 'packages': entity_fields.ListField(default=[]), | |||
| 'packages': entity_fields.StringField(), | |||
There was a problem hiding this comment.
@dosas Good catch, this field should only be a string field, but robottelo uses it as a list field only, will you be opening a PR for that too?
There was a problem hiding this comment.
Shouldn't some tests be failing if packages was passed?
I cannot find any usage of packages in robottelo tests.
RegistrationCommand is called by api_register : https://github.com/search?q=repo%3ASatelliteQE%2Frobottelo%20api_register&type=code
There was a problem hiding this comment.
ping @Gauravtalreja1
There was a problem hiding this comment.
ah, right, we've no registration tests for api's to check if packages works
There was a problem hiding this comment.
Created PR to cover this in robottelo test - SatelliteQE/robottelo#16914
Gauravtalreja1
approved these changes
Nov 14, 2024
it is a space separated string not a list https://apidocs.theforeman.org/foreman/latest/apidoc/v2/registration_commands/create.html
dosas
force-pushed
the
fix-for-registration-command-packages
branch
from
84fe64d to
c97d94b
Compare
|
@Gauravtalreja1 Thank you for the review and the testing. Do you know anybody from your team who could supply the second approval? |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
it is a space separated string not a list https://apidocs.theforeman.org/foreman/latest/apidoc/v2/registration_commands/create.html (cherry picked from commit 4f7c162)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
it is a space separated string not a list https://apidocs.theforeman.org/foreman/latest/apidoc/v2/registration_commands/create.html (cherry picked from commit 4f7c162)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
it is a space separated string not a list https://apidocs.theforeman.org/foreman/latest/apidoc/v2/registration_commands/create.html (cherry picked from commit 4f7c162)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
it is a space separated string not a list https://apidocs.theforeman.org/foreman/latest/apidoc/v2/registration_commands/create.html (cherry picked from commit 4f7c162)
This was referenced Nov 14, 2024
Gauravtalreja1
pushed a commit
that referenced
this pull request
Nov 14, 2024
it is a space separated string not a list https://apidocs.theforeman.org/foreman/latest/apidoc/v2/registration_commands/create.html (cherry picked from commit 4f7c162) Co-authored-by: dosas <dosas@users.noreply.github.com>
Gauravtalreja1
pushed a commit
that referenced
this pull request
Nov 14, 2024
it is a space separated string not a list https://apidocs.theforeman.org/foreman/latest/apidoc/v2/registration_commands/create.html (cherry picked from commit 4f7c162) Co-authored-by: dosas <dosas@users.noreply.github.com>
Gauravtalreja1
pushed a commit
that referenced
this pull request
Nov 14, 2024
it is a space separated string not a list https://apidocs.theforeman.org/foreman/latest/apidoc/v2/registration_commands/create.html (cherry picked from commit 4f7c162) Co-authored-by: dosas <dosas@users.noreply.github.com>
Gauravtalreja1
pushed a commit
that referenced
this pull request
Nov 14, 2024
it is a space separated string not a list https://apidocs.theforeman.org/foreman/latest/apidoc/v2/registration_commands/create.html (cherry picked from commit 4f7c162) Co-authored-by: dosas <dosas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is a space separated string not a list
https://apidocs.theforeman.org/foreman/latest/apidoc/v2/registration_commands/create.html