Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add network_type and remote_execution_proxy fields to Subnet #477

Merged
merged 1 commit into from
Jan 5, 2018
Merged

Add network_type and remote_execution_proxy fields to Subnet #477

merged 1 commit into from
Jan 5, 2018

Conversation

abalakh
Copy link
Contributor

@abalakh abalakh commented Jan 4, 2018 

In [2]: sn = entities.Subnet(network_type='IPv4', network='255.255.255.0', remot
   ...: e_execution_proxy=[1]).create()

In [3]: sn
Out[3]: nailgun.entities.Subnet(dns_primary=None, domain=[], name=u'cVinKe', organization=[], cidr=5, id=33, boot_mode=u'DHCP', dns_secondary=None, from=None, network=u'255.255.255.0', subnet_parameters_attributes=[], to=None, ipam=u'None', mask=u'248.0.0.0', vlanid=None, gateway=None, location=[], dns=None, dhcp=None, tftp=None, network_type=u'IPv4')

In [4]: sn.network_type
Out[4]: u'IPv4'

@abalakh abalakh added the fields label Jan 4, 2018
@abalakh abalakh self-assigned this Jan 4, 2018
@abalakh abalakh added the review label Jan 4, 2018
@abalakh abalakh mentioned this pull request Jan 4, 2018
Merged
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0009%) to 97.894% when pulling a700f68 on abalakh:subnet_fields into fca9c25 on SatelliteQE:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0009%) to 97.894% when pulling a700f68 on abalakh:subnet_fields into fca9c25 on SatelliteQE:master.

odovzhenko
odovzhenko approved these changes Jan 5, 2018
View reviewed changes
Copy link

@odovzhenko odovzhenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

ldjebran
ldjebran approved these changes Jan 5, 2018
View reviewed changes
Copy link
Contributor

@ldjebran ldjebran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ldjebran ldjebran merged commit 63fb869 into SatelliteQE:master Jan 5, 2018
@ldjebran ldjebran removed the review label Jan 5, 2018
@abalakh abalakh deleted the subnet_fields branch January 5, 2018 09:29
rplevka pushed a commit to rplevka/nailgun that referenced this pull request Jan 18, 2018
@abalakh
Add network_type and remote_execution_proxy fields to Subnet (Sat…
3f183d5 
…elliteQE#477)
@rplevka rplevka mentioned this pull request Jan 18, 2018
Closed
lpramuk pushed a commit to lpramuk/nailgun that referenced this pull request Sep 26, 2023
@abalakh @lpramuk
Add network_type and remote_execution_proxy fields to Subnet (Sat…
96c21ff 
…elliteQE#477)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odovzhenko odovzhenko odovzhenko approved these changes

@ldjebran ldjebran ldjebran approved these changes

Assignees

@abalakh abalakh

Labels
fields
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abalakh @coveralls @ldjebran @odovzhenko