Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't install tests into the binary distribution #482

Merged
merged 1 commit into from
Feb 20, 2018

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Feb 19, 2018

this tries to install a "tests" python package, which we don't own.
at the same time, also exclude docs and contrib as done in the PyPA
sample project [1]

[1] https://github.com/pypa/sampleproject/blob/master/setup.py

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.91% when pulling dc10c6f on evgeni:dont-install-tests into 6f05252 on SatelliteQE:master.

@coveralls
Copy link

coveralls commented Feb 19, 2018

Coverage Status

Coverage remained the same at 97.91% when pulling 77be985 on evgeni:dont-install-tests into 6f05252 on SatelliteQE:master.

Copy link
Contributor

@rochacbruno rochacbruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Contributor

@abalakh abalakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have contrib folder, what's the point of excluding it? Just to follow the example?

@evgeni
Copy link
Member Author

evgeni commented Feb 20, 2018

@abalakh yes. I can remove it if you like to.

@abalakh
Copy link
Contributor

abalakh commented Feb 20, 2018

@evgeni if you don't mind - pls remove it then.

this tries to install a "tests" python package, which we don't own.
at the same time, also exclude docs and contrib as done in the PyPA
sample project [1]

[1] https://github.com/pypa/sampleproject/blob/master/setup.py
@evgeni evgeni force-pushed the dont-install-tests branch from dc10c6f to 77be985 Compare February 20, 2018 09:53
@evgeni
Copy link
Member Author

evgeni commented Feb 20, 2018

@abalakh updated

Copy link
Contributor

@abalakh abalakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@abalakh abalakh merged commit 54c999f into SatelliteQE:master Feb 20, 2018
lpramuk pushed a commit to lpramuk/nailgun that referenced this pull request Sep 26, 2023
this tries to install a "tests" python package, which we don't own.
at the same time, also exclude docs and contrib as done in the PyPA
sample project [1]

[1] https://github.com/pypa/sampleproject/blob/master/setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants