Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for ContentView server_config auth values #864

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

vijaysawant
Copy link
Contributor

Description of problem
  • from api/tests function of test_contentview.py at line 1176 after call to read() get resolve auth values of "custom user" changes to "admin user".
  • server_config changed inside EntityReadMixin > read() line 826
  • So the custom user with readonly role able to perform other operations on ContentView, operations like delete, update, publish and pramote.

@vijaysawant vijaysawant added the CherryPick PR needs CherryPick to previous branches label Dec 22, 2022
@omkarkhatavkar
Copy link

Can one of the admins verify this patch?

@omkarkhatavkar
Copy link

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py -k 'test_positive_readonly_user_actions'

@omkarkhatavkar
Copy link

omkarkhatavkar commented Dec 23, 2022

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py -k 'test_negative_readonly_user_actions'

1 similar comment
@vijaysawant
Copy link
Contributor Author

vijaysawant commented Dec 23, 2022

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py -k 'test_negative_readonly_user_actions'

@omkarkhatavkar
Copy link

CI failure will be fixed by @sambible PR https://github.com/SatelliteQE/nailgun/pull/841/files#diff-da24b355349b53e4c8047034767d008e4c2ce9ea6c8933a3acd50d0828f00528R9

jyejare
jyejare previously approved these changes Dec 28, 2022
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good just add the appropriate labels for Cherrypicking.

Also please fix the CI failures by you or @sam Bible.

Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like something that we would like to have fixed not only for ContentView class, am I right?

@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py -k test_negative_readonly_user_actions

@jyejare
Copy link
Member

jyejare commented Jan 4, 2023

@ogajduse Raised MR #867 to fix unit tests failing for all open PRs now. Will merge it once the checks passing!

@codecov-commenter
Copy link

Codecov Report

Base: 93.85% // Head: 93.73% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (59600e8) compared to base (bd34895).
Patch coverage: 42.85% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #864      +/-   ##
==========================================
- Coverage   93.85%   93.73%   -0.13%     
==========================================
  Files           6        6              
  Lines        2899     2906       +7     
==========================================
+ Hits         2721     2724       +3     
- Misses        178      182       +4     
Impacted Files Coverage Δ
nailgun/entities.py 93.16% <42.85%> (-0.16%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jyejare jyejare merged commit 6d60091 into SatelliteQE:master Jan 16, 2023
github-actions bot pushed a commit that referenced this pull request Jan 16, 2023
github-actions bot pushed a commit that referenced this pull request Jan 16, 2023
@vijaysawant vijaysawant deleted the test_nailgun branch January 16, 2023 11:57
jyejare pushed a commit that referenced this pull request Jan 18, 2023
(cherry picked from commit 6d60091)

Co-authored-by: vijay sawant <vijaysawant36@gmail.com>
jyejare pushed a commit that referenced this pull request Jan 18, 2023
(cherry picked from commit 6d60091)

Co-authored-by: vijay sawant <vijaysawant36@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.12.z 6.13.z CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants