-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for ContentView server_config auth values #864
Conversation
Can one of the admins verify this patch? |
trigger: test-robottelo |
trigger: test-robottelo |
1 similar comment
trigger: test-robottelo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good just add the appropriate labels for Cherrypicking.
Also please fix the CI failures by you or @sam Bible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like something that we would like to have fixed not only for ContentView
class, am I right?
trigger: test-robottelo |
Codecov ReportBase: 93.85% // Head: 93.73% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #864 +/- ##
==========================================
- Coverage 93.85% 93.73% -0.13%
==========================================
Files 6 6
Lines 2899 2906 +7
==========================================
+ Hits 2721 2724 +3
- Misses 178 182 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
(cherry picked from commit 6d60091)
(cherry picked from commit 6d60091)
Description of problem