Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.9 support from nailgun #967

Merged
merged 5 commits into from
Jul 24, 2023

Conversation

LadislavVasina1
Copy link
Contributor

Description of changes

As discussed on slack, we are removing support for Python 3.9 from our frameworks.

@LadislavVasina1 LadislavVasina1 self-assigned this Jul 24, 2023
@LadislavVasina1 LadislavVasina1 added CherryPick PR needs CherryPick to previous branches Framework Changes Framework level Changes to the Nailgun 6.11.z 6.12.z 6.13.z 6.14.z labels Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e664f39) 92.26% compared to head (f4d1918) 92.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #967   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files           6        6           
  Lines        3076     3076           
=======================================
  Hits         2838     2838           
  Misses        238      238           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LadislavVasina1 LadislavVasina1 marked this pull request as ready for review July 24, 2023 07:30
@LadislavVasina1 LadislavVasina1 requested review from a team and adarshdubey-star July 24, 2023 07:30
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Build and Publish job in merge-to-master GHA needs to change the python-version to 3.10 now.
  2. setup.py also needs to update the python-requires to minimum 3.10

setup.py Show resolved Hide resolved
@LadislavVasina1 LadislavVasina1 requested a review from jyejare July 24, 2023 08:30
@Gauravtalreja1 Gauravtalreja1 merged commit 4694e95 into master Jul 24, 2023
@Gauravtalreja1 Gauravtalreja1 deleted the LadislavVasina1-patch-1 branch July 24, 2023 10:00
github-actions bot pushed a commit that referenced this pull request Jul 24, 2023
* Remove Python 3.9 support from nailgun

* Update merge_to_master.yml

* Update setup.py

* Change build and publish section in merge_to_master.yml

* Update setup.py

(cherry picked from commit 4694e95)
github-actions bot pushed a commit that referenced this pull request Jul 24, 2023
* Remove Python 3.9 support from nailgun

* Update merge_to_master.yml

* Update setup.py

* Change build and publish section in merge_to_master.yml

* Update setup.py

(cherry picked from commit 4694e95)
github-actions bot pushed a commit that referenced this pull request Jul 24, 2023
* Remove Python 3.9 support from nailgun

* Update merge_to_master.yml

* Update setup.py

* Change build and publish section in merge_to_master.yml

* Update setup.py

(cherry picked from commit 4694e95)
github-actions bot pushed a commit that referenced this pull request Jul 24, 2023
* Remove Python 3.9 support from nailgun

* Update merge_to_master.yml

* Update setup.py

* Change build and publish section in merge_to_master.yml

* Update setup.py

(cherry picked from commit 4694e95)
Gauravtalreja1 pushed a commit that referenced this pull request Jul 24, 2023
* Remove Python 3.9 support from nailgun

* Update merge_to_master.yml

* Update setup.py

* Change build and publish section in merge_to_master.yml

* Update setup.py

(cherry picked from commit 4694e95)

Co-authored-by: Ladislav Vašina <ladislavvasina@gmail.com>
Gauravtalreja1 pushed a commit that referenced this pull request Jul 24, 2023
* Remove Python 3.9 support from nailgun

* Update merge_to_master.yml

* Update setup.py

* Change build and publish section in merge_to_master.yml

* Update setup.py

(cherry picked from commit 4694e95)

Co-authored-by: Ladislav Vašina <ladislavvasina@gmail.com>
Gauravtalreja1 pushed a commit that referenced this pull request Jul 24, 2023
* Remove Python 3.9 support from nailgun

* Update merge_to_master.yml

* Update setup.py

* Change build and publish section in merge_to_master.yml

* Update setup.py

(cherry picked from commit 4694e95)

Co-authored-by: Ladislav Vašina <ladislavvasina@gmail.com>
Gauravtalreja1 pushed a commit that referenced this pull request Jul 24, 2023
* Remove Python 3.9 support from nailgun

* Update merge_to_master.yml

* Update setup.py

* Change build and publish section in merge_to_master.yml

* Update setup.py

(cherry picked from commit 4694e95)

Co-authored-by: Ladislav Vašina <ladislavvasina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.11.z 6.12.z 6.13.z 6.14.z CherryPick PR needs CherryPick to previous branches Framework Changes Framework level Changes to the Nailgun
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants