-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Python 3.9 support from nailgun #967
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LadislavVasina1
added
CherryPick
PR needs CherryPick to previous branches
Framework Changes
Framework level Changes to the Nailgun
6.11.z
6.12.z
6.13.z
6.14.z
labels
Jul 24, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #967 +/- ##
=======================================
Coverage 92.26% 92.26%
=======================================
Files 6 6
Lines 3076 3076
=======================================
Hits 2838 2838
Misses 238 238 ☔ View full report in Codecov by Sentry. |
jyejare
requested changes
Jul 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build and Publish
job in merge-to-master GHA needs to change the python-version to 3.10 now.- setup.py also needs to update the
python-requires
to minimum 3.10
jyejare
approved these changes
Jul 24, 2023
adarshdubey-star
approved these changes
Jul 24, 2023
Gauravtalreja1
approved these changes
Jul 24, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
* Remove Python 3.9 support from nailgun * Update merge_to_master.yml * Update setup.py * Change build and publish section in merge_to_master.yml * Update setup.py (cherry picked from commit 4694e95)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
* Remove Python 3.9 support from nailgun * Update merge_to_master.yml * Update setup.py * Change build and publish section in merge_to_master.yml * Update setup.py (cherry picked from commit 4694e95)
This was referenced Jul 24, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
* Remove Python 3.9 support from nailgun * Update merge_to_master.yml * Update setup.py * Change build and publish section in merge_to_master.yml * Update setup.py (cherry picked from commit 4694e95)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
* Remove Python 3.9 support from nailgun * Update merge_to_master.yml * Update setup.py * Change build and publish section in merge_to_master.yml * Update setup.py (cherry picked from commit 4694e95)
Gauravtalreja1
pushed a commit
that referenced
this pull request
Jul 24, 2023
* Remove Python 3.9 support from nailgun * Update merge_to_master.yml * Update setup.py * Change build and publish section in merge_to_master.yml * Update setup.py (cherry picked from commit 4694e95) Co-authored-by: Ladislav Vašina <ladislavvasina@gmail.com>
Gauravtalreja1
pushed a commit
that referenced
this pull request
Jul 24, 2023
* Remove Python 3.9 support from nailgun * Update merge_to_master.yml * Update setup.py * Change build and publish section in merge_to_master.yml * Update setup.py (cherry picked from commit 4694e95) Co-authored-by: Ladislav Vašina <ladislavvasina@gmail.com>
Gauravtalreja1
pushed a commit
that referenced
this pull request
Jul 24, 2023
* Remove Python 3.9 support from nailgun * Update merge_to_master.yml * Update setup.py * Change build and publish section in merge_to_master.yml * Update setup.py (cherry picked from commit 4694e95) Co-authored-by: Ladislav Vašina <ladislavvasina@gmail.com>
Gauravtalreja1
pushed a commit
that referenced
this pull request
Jul 24, 2023
* Remove Python 3.9 support from nailgun * Update merge_to_master.yml * Update setup.py * Change build and publish section in merge_to_master.yml * Update setup.py (cherry picked from commit 4694e95) Co-authored-by: Ladislav Vašina <ladislavvasina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.11.z
6.12.z
6.13.z
6.14.z
CherryPick
PR needs CherryPick to previous branches
Framework Changes
Framework level Changes to the Nailgun
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
As discussed on slack, we are removing support for Python 3.9 from our frameworks.