Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ansible_Job api test coverage [e2e] #10497

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Ansible_Job api test coverage [e2e] #10497

merged 1 commit into from
Jan 19, 2023

Conversation

adarshdubey-star
Copy link
Contributor

Test results:

pytest tests/foreman/api/test_ansible.py -k test_positive_ansible_job_on_host
============================================================== test session starts ===============================================================
platform linux -- Python 3.8.13, pytest-7.2.0, pluggy-1.0.0
shared_function enabled - OFF - scope:  - storage: file
rootdir: /home/addubey/work/robottelo, configfile: pyproject.toml
plugins: forked-1.4.0, services-2.2.1, cov-3.0.0, xdist-3.1.0, ibutsu-2.2.4, reportportal-5.1.3, mock-3.10.0
collected 4 items / 1 deselected / 3 selected                                                                                                    

tests/foreman/api/test_ansible.py ...                                                                                                      [100%]
============================================ 3 passed, 1 deselected, 5 warnings in 1487.51s (0:24:47) ============================================

Signed-off-by: Adarsh Dubey addubey@redhat.com

@adarshdubey-star adarshdubey-star added API Issues and PRs involving the API QETestCoverage Issues and PRs relating to a Satellite bug 6.11.z Introduced in or relating directly to Satellite 6.11 CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 labels Jan 9, 2023
@adarshdubey-star adarshdubey-star self-assigned this Jan 9, 2023
@adarshdubey-star
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_ansible.py -k test_positive_ansible_job_on_host
nailgun: 841

@adarshdubey-star adarshdubey-star force-pushed the api_ansible branch 2 times, most recently from 52821a7 to 898670a Compare January 9, 2023 13:38
synkd
synkd reviewed Jan 9, 2023
View reviewed changes
Copy link
Contributor

@synkd synkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like your PRT run failed because SatelliteQE/nailgun#841 does not contain the changes that you made in SatelliteQE/nailgun#866. So, while I trust your local results and the test in this PR looks good to me, the PRT failure does point to the fact that this test depends on both of the above nailgun PRs. Should we hold off on merging this until nailgun 841 is merged?

@adarshdubey-star
Copy link
Contributor Author

Looks like your PRT run failed because SatelliteQE/nailgun#841 does not contain the changes that you made in SatelliteQE/nailgun#866. So, while I trust your local results and the test in this PR looks good to me, the PRT failure does point to the fact that this test depends on both of the above nailgun PRs. Should we hold off on merging this until nailgun 841 is merged?

Yes @synkd 841 should go in first as this test case utilizes those endpoints.

Griffin-Sullivan
Griffin-Sullivan approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome coverage to get in for stream testing! We could even consider that this is testing RH Cloud - Insights as a sub-component if we ever want to start adding metadata for sub-component.

tests/foreman/api/test_ansible.py Outdated Show resolved Hide resolved
Gauravtalreja1
Gauravtalreja1 reviewed Jan 13, 2023
View reviewed changes
tests/foreman/api/test_ansible.py Outdated Show resolved Hide resolved
tests/foreman/api/test_ansible.py Outdated Show resolved Hide resolved
tests/foreman/api/test_ansible.py Outdated Show resolved Hide resolved
tests/foreman/api/test_ansible.py Show resolved Hide resolved
tests/foreman/api/test_ansible.py Outdated Show resolved Hide resolved
tests/foreman/api/test_ansible.py Outdated Show resolved Hide resolved
ColeHiggins2
ColeHiggins2 approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@ColeHiggins2 ColeHiggins2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack pending @Gauravtalreja1 comments

@adarshdubey-star
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_ansible.py -k test_positive_ansible_job_on_host

@adarshdubey-star
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_ansible.py -k test_positive_ansible_job_on_host
nailgun: 881

@adarshdubey-star
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_ansible.py -k test_positive_ansible_job_on_host
nailgun: 881

@adarshdubey-star
Ansible_Job api test coverage [e2e]
cf57f35 
Signed-off-by: Adarsh Dubey <addubey@redhat.com>
@adarshdubey-star
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_ansible.py -k test_positive_ansible_job_on_host
nailgun: 881

@Gauravtalreja1 Gauravtalreja1 added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Jan 19, 2023
@Gauravtalreja1 Gauravtalreja1 removed the 6.11.z Introduced in or relating directly to Satellite 6.11 label Jan 19, 2023
@Gauravtalreja1 Gauravtalreja1 merged commit a435528 into SatelliteQE:master Jan 19, 2023
This was referenced Jan 19, 2023
Merged
Merged
github-actions bot pushed a commit that referenced this pull request Jan 19, 2023
@adarshdubey-star @web-flow
Ansible_Job api test coverage [e2e] (#10497)
08490b1 
Signed-off-by: Adarsh Dubey <addubey@redhat.com>

Signed-off-by: Adarsh Dubey <addubey@redhat.com>
(cherry picked from commit a435528)
github-actions bot pushed a commit that referenced this pull request Jan 19, 2023
@adarshdubey-star @web-flow
Ansible_Job api test coverage [e2e] (#10497)
c39f7a2 
Signed-off-by: Adarsh Dubey <addubey@redhat.com>

Signed-off-by: Adarsh Dubey <addubey@redhat.com>
(cherry picked from commit a435528)
Gauravtalreja1 pushed a commit that referenced this pull request Feb 7, 2023
@adarshdubey-star @Gauravtalreja1
Ansible_Job api test coverage [e2e] (#10497)
ce68b25 
Signed-off-by: Adarsh Dubey <addubey@redhat.com>

Signed-off-by: Adarsh Dubey <addubey@redhat.com>
(cherry picked from commit a435528)
Gauravtalreja1 pushed a commit that referenced this pull request Feb 7, 2023
@adarshdubey-star @Gauravtalreja1
Ansible_Job api test coverage [e2e] (#10497)
08b2042 
Signed-off-by: Adarsh Dubey <addubey@redhat.com>

Signed-off-by: Adarsh Dubey <addubey@redhat.com>
(cherry picked from commit a435528)
Gauravtalreja1 pushed a commit that referenced this pull request Feb 8, 2023
@Satellite-QE @adarshdubey-star
[6.13.z] Ansible_Job api test coverage [e2e] (#10553)
455a3d6 
Ansible_Job api test coverage [e2e] (#10497)

Signed-off-by: Adarsh Dubey <addubey@redhat.com>

Signed-off-by: Adarsh Dubey <addubey@redhat.com>
(cherry picked from commit a435528)

Co-authored-by: Adarsh dubey <addubey@redhat.com>
Gauravtalreja1 pushed a commit that referenced this pull request Feb 8, 2023
@Satellite-QE @adarshdubey-star
[6.12.z] Ansible_Job api test coverage [e2e] (#10552)
98b055e 
Ansible_Job api test coverage [e2e] (#10497)

Signed-off-by: Adarsh Dubey <addubey@redhat.com>

Signed-off-by: Adarsh Dubey <addubey@redhat.com>
(cherry picked from commit a435528)

Co-authored-by: Adarsh dubey <addubey@redhat.com>
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@adarshdubey-star @shweta83
Ansible_Job api test coverage [e2e] (SatelliteQE#10497)
1a59312 
Signed-off-by: Adarsh Dubey <addubey@redhat.com>

Signed-off-by: Adarsh Dubey <addubey@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Griffin-Sullivan Griffin-Sullivan Griffin-Sullivan approved these changes

@synkd synkd synkd approved these changes

@ColeHiggins2 ColeHiggins2 ColeHiggins2 approved these changes

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@pondrejk pondrejk pondrejk approved these changes

Assignees

@adarshdubey-star adarshdubey-star

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 API Issues and PRs involving the API AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adarshdubey-star @pondrejk @Gauravtalreja1 @ColeHiggins2 @synkd @Griffin-Sullivan