Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Coverage for FDI version verification #13209

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Test Coverage for FDI version verification #13209

merged 4 commits into from
Dec 7, 2023

Conversation

adarshdubey-star
Copy link
Contributor

Problem Statement

The versioning of the foreman discovery image should be consistent or greater in the latest version of the satellite.

Solution

Save the FDI version pre_upgrade and post upgrading check the version.

Related Issues

Bugzilla

@adarshdubey-star adarshdubey-star requested a review from a team as a code owner November 29, 2023 10:14
@adarshdubey-star adarshdubey-star self-assigned this Nov 29, 2023
@adarshdubey-star adarshdubey-star added QETestCoverage Issues and PRs relating to a Satellite bug 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches labels Nov 29, 2023
jameerpathan111
jameerpathan111 requested changes Nov 30, 2023
View reviewed changes
tests/upgrades/test_discovery.py Outdated Show resolved Hide resolved
tests/upgrades/test_discovery.py Outdated Show resolved Hide resolved
lhellebr
lhellebr reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@lhellebr lhellebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no expert in FDI but a lot of things seem fishy to me, I left quite a few comments.

tests/upgrades/test_discovery.py Outdated Show resolved Hide resolved
tests/upgrades/test_discovery.py Outdated Show resolved Hide resolved
tests/upgrades/test_discovery.py Outdated Show resolved Hide resolved
tests/upgrades/test_discovery.py Outdated Show resolved Hide resolved
tests/upgrades/test_discovery.py Outdated Show resolved Hide resolved
tests/upgrades/test_discovery.py Outdated Show resolved Hide resolved
@adarshdubey-star adarshdubey-star added the in progress This issue is being worked on label Dec 4, 2023
@adarshdubey-star
Copy link
Contributor Author

adarshdubey-star commented Dec 6, 2023 •
edited
Loading

Test result :

Pre-upgrade

pytest --disable-pytest-warnings -m pre_upgrade tests/upgrades/test_discovery.py -sv

========================================================================== test session starts ==========================================================================                                                                                                           tests/upgrades/test_discovery.py::TestDiscoveryImage::test_pre_upgrade_fdi_version PASSED

======================================================== 1 passed, 1 deselected, 1 warning in 129.28s (0:02:09) =========================================================

Post-upgrade

pytest tests/upgrades/test_discovery.py -k test_post_upgrade_fdi_version -m post_upgrade
========================================================================== test session starts ==========================================================================

collected 2 items / 1 deselected / 1 selected                                                                                                                           

tests/upgrades/test_discovery.py .                                                                                                                                [100%]

=========================================================================== warnings summary ============================================================================

============================================================== 1 passed, 1 deselected, 1 warning in 12.37s ==============================================================

@adarshdubey-star adarshdubey-star removed the in progress This issue is being worked on label Dec 7, 2023
@Gauravtalreja1 Gauravtalreja1 added the Upgrades Issues and PRs related to upgrades label Dec 7, 2023
@adarshdubey-star adarshdubey-star force-pushed the discovery_upgrade branch 2 times, most recently from f7f2c4f to 6f92901 Compare December 7, 2023 09:47
@Gauravtalreja1 Gauravtalreja1 merged commit 18acd55 into SatelliteQE:master Dec 7, 2023
5 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 7, 2023
@adarshdubey-star @web-flow
Test Coverage for FDI version verification (#13209)
a7e0bfe 
* Test Coverage for FDI version verification

* Removed unwanted code

* Using foreman-maintain for installation

* Using Version

(cherry picked from commit 18acd55)
github-actions bot pushed a commit that referenced this pull request Dec 7, 2023
@adarshdubey-star @web-flow
Test Coverage for FDI version verification (#13209)
87b6787 
* Test Coverage for FDI version verification

* Removed unwanted code

* Using foreman-maintain for installation

* Using Version

(cherry picked from commit 18acd55)
github-actions bot pushed a commit that referenced this pull request Dec 7, 2023
@adarshdubey-star @web-flow
Test Coverage for FDI version verification (#13209)
0ef1579 
* Test Coverage for FDI version verification

* Removed unwanted code

* Using foreman-maintain for installation

* Using Version

(cherry picked from commit 18acd55)
This was referenced Dec 7, 2023
Merged
Merged
Merged
Gauravtalreja1 pushed a commit that referenced this pull request Dec 7, 2023
@Satellite-QE @adarshdubey-star
[6.14.z] Test Coverage for FDI version verification (#13321)
b0ebf4d 
Test Coverage for FDI version verification (#13209)

* Test Coverage for FDI version verification

* Removed unwanted code

* Using foreman-maintain for installation

* Using Version

(cherry picked from commit 18acd55)

Co-authored-by: Adarsh dubey <addubey@redhat.com>
Gauravtalreja1 pushed a commit that referenced this pull request Dec 7, 2023
@Satellite-QE @adarshdubey-star
[6.15.z] Test Coverage for FDI version verification (#13322)
81927b0 
Test Coverage for FDI version verification (#13209)

* Test Coverage for FDI version verification

* Removed unwanted code

* Using foreman-maintain for installation

* Using Version

(cherry picked from commit 18acd55)

Co-authored-by: Adarsh dubey <addubey@redhat.com>
Gauravtalreja1 pushed a commit that referenced this pull request Dec 7, 2023
@Satellite-QE @adarshdubey-star
[6.13.z] Test Coverage for FDI version verification (#13323)
e55a984 
Test Coverage for FDI version verification (#13209)

* Test Coverage for FDI version verification

* Removed unwanted code

* Using foreman-maintain for installation

* Using Version

(cherry picked from commit 18acd55)

Co-authored-by: Adarsh dubey <addubey@redhat.com>
damoore044 pushed a commit to damoore044/robottelo that referenced this pull request Dec 11, 2023
@adarshdubey-star @damoore044
Test Coverage for FDI version verification (SatelliteQE#13209)
1b9878e 
* Test Coverage for FDI version verification

* Removed unwanted code

* Using foreman-maintain for installation

* Using Version
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@adarshdubey-star @shweta83
Test Coverage for FDI version verification (SatelliteQE#13209)
ef84148 
* Test Coverage for FDI version verification

* Removed unwanted code

* Using foreman-maintain for installation

* Using Version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@lhellebr lhellebr lhellebr approved these changes

@jameerpathan111 jameerpathan111 Awaiting requested review from jameerpathan111

Assignees

@adarshdubey-star adarshdubey-star

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches QETestCoverage Issues and PRs relating to a Satellite bug Upgrades Issues and PRs related to upgrades
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adarshdubey-star @lhellebr @jameerpathan111 @Gauravtalreja1