Errata with swidtags setup and modular update #14494

damoore044 · 2024-03-22T11:30:13Z

Problem Statement

Setup for contenthost of api::test_errata_installation_with_swidtags uses some outdated repositories and makes use of deprecated method repo_collection.setup_virtual_machine(). Has failed in most recent automation runs for 6.15, 6.14.3

Solution

Setup host with global registration to published CV and AK, with synced repos containing prereqs and module stream with swidtag attached, promoted CVV with all content. Also using SCA-only org fixture

Related Issues

Failing contenthost setup or prereq install commands in recent 6.15 and 6.14 CI.
~~these fixes have been included in an open CP for API::Errata-Management , which is not merged due to this failing test.~~ This is now merged into 6.14.z ([6.14.z] CP of API-Errata modifications #13832)
^ We should CP to 6.14.z still, because review comments have brought enhancements to these fixes.

PRT case

trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py::test_errata_installation_with_swidtags

damoore044 · 2024-03-22T12:00:51Z

trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py::test_errata_installation_with_swidtags

Satellite-QE · 2024-03-22T12:38:21Z

PRT Result

Build Number: 6167
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_errata.py::test_errata_installation_with_swidtags --external-logging
Test Result : ================== 1 passed, 2 warnings in 1893.11s (0:31:33) ==================

vsedmik

Few questions pending.

tests/foreman/api/test_errata.py

damoore044 · 2024-03-25T14:16:50Z

trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py::test_errata_installation_with_swidtags

Satellite-QE · 2024-03-25T14:44:02Z

PRT Result

Build Number: 6183
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_errata.py::test_errata_installation_with_swidtags --external-logging
Test Result : ================== 1 passed, 1 warning in 1370.78s (0:22:50) ===================

damoore044 · 2024-03-25T15:29:38Z

trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py::test_errata_installation_with_swidtags

Satellite-QE · 2024-03-25T15:58:46Z

PRT Result

Build Number: 6188
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_errata.py::test_errata_installation_with_swidtags --external-logging
Test Result : ================== 1 passed, 1 warning in 1374.40s (0:22:54) ===================

vijaysawant

Non-blocking

tests/foreman/api/test_errata.py

damoore044 · 2024-03-28T20:07:16Z

trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py::test_errata_installation_with_swidtags

damoore044 · 2024-04-03T16:33:24Z

trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py::test_errata_installation_with_swidtags

Satellite-QE · 2024-04-03T17:05:26Z

PRT Result

Build Number: 6297
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_errata.py::test_errata_installation_with_swidtags --external-logging
Test Result : ================== 1 passed, 4 warnings in 1422.95s (0:23:42) ==================

vijaysawant

Request to update doc string for the function fetch_cv_by_name_and_cvv.

vijaysawant · 2024-04-03T17:17:17Z

tests/foreman/api/test_errata.py

+    return target_sat.api.LifecycleEnvironment(organization=module_sca_manifest_org).create()
+
+
+def fetch_cv_by_name_and_cvv(sat, org, name=DEFAULT_CV, ver=None):


Which test is calling this function?
Also could you please add :param: section which explain meaning of each parameter?

Suggested change

def fetch_cv_by_name_and_cvv(sat, org, name=DEFAULT_CV, ver=None):

def fetch_cv_by_name_and_cvv(sat, org, name=DEFAULT_CV, ver=None):

""" Doc string

:param: <type> sat:

:param: <type> org:

:param: <type> name:

:param: <type> ver:

"""

Planned for next PR of a few enhancements, but is unneeded for now.
Will remove from here, and put up w/ requested changes once fully implemented

JacobCallahan · 2024-04-03T18:13:20Z

tests/foreman/api/test_errata.py

-    _set_prerequisites_for_swid_repos(rhel8_contenthost)
-    _run_remote_command_on_content_host(
-        f'dnf -y module install {module_name}:0:{version}', rhel8_contenthost
+    _repos = {


there's no need to use a leading underscore within a test

Suggested change

_repos = {

repos = {

JacobCallahan · 2024-04-03T18:14:18Z

tests/foreman/api/test_errata.py

+        'swid_tags': settings.repos.swid_tag.url,  # module stream pkgs and errata
+    }
+    # associate repos with sat, org, lce, cv, and sync
+    for _r_ in _repos:


same comment about leading underscores, but this also has a tailing underscore.

Suggested change

for _r_ in _repos:

for r in repos:

JacobCallahan · 2024-04-03T18:18:44Z

tests/foreman/api/test_errata.py

    _run_remote_command_on_content_host('mv *swid*.repo /etc/yum.repos.d', vm)
-    _run_remote_command_on_content_host(r'subscription-manager repos --enable \*', vm)
    _run_remote_command_on_content_host('yum install -y swid-tools', vm)
    _run_remote_command_on_content_host('yum install -y dnf-plugin-swidtags', vm)


not within the scope of this PR (and not blocking), but this function needs to go away.

agreed, can get this done for the next errata maintenance pr

vsedmik

LGTM, plus-one to get rid of _s (pending)

damoore044 · 2024-04-03T19:07:15Z

trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py::test_errata_installation_with_swidtags

Satellite-QE · 2024-04-03T19:39:46Z

PRT Result

Build Number: 6301
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_errata.py::test_errata_installation_with_swidtags --external-logging
Test Result : ================== 1 passed, 4 warnings in 1403.49s (0:23:23) ==================

JacobCallahan · 2024-04-03T22:13:10Z

tests/foreman/api/test_errata.py

+    _ak = target_sat.api.ActivationKey(
+        organization=org,
+        environment=lce,
+        content_view=cv,
+    ).create()
+    # register host with ak, succeeds
+    result = rhel_contenthost.register(
+        activation_keys=_ak.name,


Very close! Just one more that I see.

Suggested change

_ak = target_sat.api.ActivationKey(

organization=org,

environment=lce,

content_view=cv,

).create()

# register host with ak, succeeds

result = rhel_contenthost.register(

activation_keys=_ak.name,

ak = target_sat.api.ActivationKey(

organization=org,

environment=lce,

content_view=cv,

).create()

# register host with ak, succeeds

result = rhel_contenthost.register(

activation_keys=ak.name,

Repair setup for package w/ swidtag, install and modular update (cherry picked from commit 9fc762a)

Repair setup for package w/ swidtag, install and modular update

damoore044 added CherryPick PR needs CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master 6.15.z Introduced in or relating directly to Satellite 6.15 labels Mar 22, 2024

damoore044 requested a review from a team as a code owner March 22, 2024 11:30

github-actions bot assigned damoore044 Mar 22, 2024

damoore044 requested a review from a team March 22, 2024 11:30

damoore044 force-pushed the errata-swidtags branch from b43b3b7 to dea50d9 Compare March 22, 2024 12:00

damoore044 changed the title ~~Errata with swidtags setup~~ Errata with swidtags setup and modular update Mar 22, 2024

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 22, 2024

vsedmik requested changes Mar 22, 2024

View reviewed changes

tests/foreman/api/test_errata.py Outdated Show resolved Hide resolved

tests/foreman/api/test_errata.py Outdated Show resolved Hide resolved

tests/foreman/api/test_errata.py Outdated Show resolved Hide resolved

tests/foreman/api/test_errata.py Outdated Show resolved Hide resolved

damoore044 force-pushed the errata-swidtags branch from dea50d9 to 146a3c9 Compare March 25, 2024 13:36

Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 25, 2024

damoore044 force-pushed the errata-swidtags branch from 146a3c9 to 53c7b83 Compare March 25, 2024 14:16

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 25, 2024

damoore044 added the 6.14.z Introduced in or relating directly to Satellite 6.14 label Mar 25, 2024

damoore044 force-pushed the errata-swidtags branch from 53c7b83 to 3b2f1b9 Compare March 25, 2024 15:29

Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 25, 2024

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 25, 2024

vijaysawant reviewed Mar 26, 2024

View reviewed changes

tests/foreman/api/test_errata.py Outdated Show resolved Hide resolved

lhellebr reviewed Mar 26, 2024

View reviewed changes

tests/foreman/api/test_errata.py Outdated Show resolved Hide resolved

damoore044 force-pushed the errata-swidtags branch from 3b2f1b9 to 3c0ec28 Compare March 27, 2024 13:59

Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 27, 2024

damoore044 force-pushed the errata-swidtags branch from 3c0ec28 to be5f7a5 Compare March 28, 2024 15:21

damoore044 force-pushed the errata-swidtags branch from 1487341 to 89e8bcc Compare April 3, 2024 16:26

Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 3, 2024

damoore044 force-pushed the errata-swidtags branch from 89e8bcc to 4845dea Compare April 3, 2024 16:32

damoore044 force-pushed the errata-swidtags branch from 4845dea to fe90fe1 Compare April 3, 2024 16:56

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 3, 2024

vijaysawant requested changes Apr 3, 2024

View reviewed changes

damoore044 force-pushed the errata-swidtags branch from fe90fe1 to faa3216 Compare April 3, 2024 17:56

Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 3, 2024

JacobCallahan requested changes Apr 3, 2024

View reviewed changes

vsedmik approved these changes Apr 3, 2024

View reviewed changes

damoore044 force-pushed the errata-swidtags branch from faa3216 to c9b7921 Compare April 3, 2024 19:01

damoore044 requested review from vijaysawant and JacobCallahan April 3, 2024 19:05

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 3, 2024

JacobCallahan requested changes Apr 3, 2024

View reviewed changes

Repair setup for package w/ swidtag, install and modular update

187bff9

damoore044 force-pushed the errata-swidtags branch from c9b7921 to 187bff9 Compare April 3, 2024 22:36

damoore044 requested a review from JacobCallahan April 3, 2024 22:36

Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 3, 2024

JacobCallahan approved these changes Apr 3, 2024

View reviewed changes

JacobCallahan merged commit 9fc762a into SatelliteQE:master Apr 3, 2024
8 checks passed

github-actions bot pushed a commit that referenced this pull request Apr 3, 2024

Errata with swidtags setup and modular update (#14494)

00a6d04

Repair setup for package w/ swidtag, install and modular update (cherry picked from commit 9fc762a)

This was referenced Apr 3, 2024

[6.15.z] Errata with swidtags setup and modular update #14618

Merged

[Failed-AutoCherryPick] - Errata with swidtags setup and modular update #14619

Closed

damoore044 mentioned this pull request Apr 4, 2024

[6.14.z] Repair setup for package w/ swidtag, install and modular update #14625

Merged

shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024

Errata with swidtags setup and modular update (SatelliteQE#14494)

91a49e5

Repair setup for package w/ swidtag, install and modular update

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Errata with swidtags setup and modular update #14494

Errata with swidtags setup and modular update #14494

damoore044 commented Mar 22, 2024 •

edited

Loading

damoore044 commented Mar 22, 2024

Satellite-QE commented Mar 22, 2024

vsedmik left a comment

damoore044 commented Mar 25, 2024

Satellite-QE commented Mar 25, 2024

damoore044 commented Mar 25, 2024

Satellite-QE commented Mar 25, 2024

vijaysawant left a comment

damoore044 commented Mar 28, 2024

damoore044 commented Apr 3, 2024

Satellite-QE commented Apr 3, 2024

vijaysawant left a comment

vijaysawant Apr 3, 2024

damoore044 Apr 3, 2024

JacobCallahan Apr 3, 2024

JacobCallahan Apr 3, 2024

JacobCallahan Apr 3, 2024

damoore044 Apr 3, 2024

vsedmik left a comment

damoore044 commented Apr 3, 2024

Satellite-QE commented Apr 3, 2024

JacobCallahan Apr 3, 2024

		return target_sat.api.LifecycleEnvironment(organization=module_sca_manifest_org).create()


		def fetch_cv_by_name_and_cvv(sat, org, name=DEFAULT_CV, ver=None):

-def fetch_cv_by_name_and_cvv(sat, org, name=DEFAULT_CV, ver=None):
+def fetch_cv_by_name_and_cvv(sat, org, name=DEFAULT_CV, ver=None):
+    """ Doc string
+    :param: <type> sat:
+    :param: <type> org:
+    :param: <type> name:
+    :param: <type> ver:
+     """

Errata with swidtags setup and modular update #14494

Errata with swidtags setup and modular update #14494

Conversation

damoore044 commented Mar 22, 2024 • edited Loading

Problem Statement

Solution

Related Issues

PRT case

damoore044 commented Mar 22, 2024

Satellite-QE commented Mar 22, 2024

vsedmik left a comment

Choose a reason for hiding this comment

damoore044 commented Mar 25, 2024

Satellite-QE commented Mar 25, 2024

damoore044 commented Mar 25, 2024

Satellite-QE commented Mar 25, 2024

vijaysawant left a comment

Choose a reason for hiding this comment

damoore044 commented Mar 28, 2024

damoore044 commented Apr 3, 2024

Satellite-QE commented Apr 3, 2024

vijaysawant left a comment

Choose a reason for hiding this comment

vijaysawant Apr 3, 2024

Choose a reason for hiding this comment

damoore044 Apr 3, 2024

Choose a reason for hiding this comment

JacobCallahan Apr 3, 2024

Choose a reason for hiding this comment

JacobCallahan Apr 3, 2024

Choose a reason for hiding this comment

JacobCallahan Apr 3, 2024

Choose a reason for hiding this comment

damoore044 Apr 3, 2024

Choose a reason for hiding this comment

vsedmik left a comment

Choose a reason for hiding this comment

damoore044 commented Apr 3, 2024

Satellite-QE commented Apr 3, 2024

JacobCallahan Apr 3, 2024

Choose a reason for hiding this comment

damoore044 commented Mar 22, 2024 •

edited

Loading