Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test parametrization more readable #14569

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Make test parametrization more readable #14569

merged 1 commit into from
Apr 5, 2024

Conversation

dosas
Copy link
Collaborator

@dosas dosas commented Mar 28, 2024

[yum] [docker]
vs
[2] [1]

@dosas dosas requested a review from a team as a code owner March 28, 2024 15:20
omkarkhatavkar
omkarkhatavkar approved these changes Apr 2, 2024
View reviewed changes
Copy link

@omkarkhatavkar omkarkhatavkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, I like it.

ColeHiggins2
ColeHiggins2 approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@ColeHiggins2 ColeHiggins2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@dosas
Copy link
Collaborator Author

dosas commented Apr 3, 2024

Somebody needs to set the labels, I can't.

@sambible sambible added CherryPick PR needs CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Apr 3, 2024
@sambible
Copy link
Contributor

sambible commented Apr 3, 2024

Do we need to cherrypick this back further? 6.15 and 6.14 seems good enough to me.

@Griffin-Sullivan
Copy link
Contributor

You'll need to rebase with https://github.com/SatelliteQE/robottelo/pull/14608/files

@dosas
Make test parametrization more readable
e6bbdf6 
[yum] [docker]
vs
[2] [1]
@dosas dosas force-pushed the more-readable-test-parametrization branch from 2ac0c09 to e6bbdf6 Compare April 4, 2024 07:40
@ogajduse ogajduse merged commit 5ad4d39 into SatelliteQE:master Apr 5, 2024
7 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 5, 2024
@dosas @web-flow
Make test parametrization more readable (#14569)
0735ddc 
(cherry picked from commit 5ad4d39)
This was referenced Apr 5, 2024
Merged
Closed
ogajduse pushed a commit to ogajduse/robottelo that referenced this pull request Apr 5, 2024
@dosas @ogajduse
Make test parametrization more readable (SatelliteQE#14569)
9ebf041
@ogajduse ogajduse mentioned this pull request Apr 5, 2024
Merged
Gauravtalreja1 pushed a commit that referenced this pull request Apr 5, 2024
@ogajduse @dosas
[6.14.z] Make test parametrization more readable (#14569) (#14644)
6a0596e 
Make test parametrization more readable (#14569)

Co-authored-by: dosas <dosas@users.noreply.github.com>
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@dosas @shweta83
Make test parametrization more readable (SatelliteQE#14569)
872ed05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColeHiggins2 ColeHiggins2 ColeHiggins2 approved these changes

@ogajduse ogajduse ogajduse approved these changes

@sambible sambible sambible approved these changes

@omkarkhatavkar omkarkhatavkar omkarkhatavkar approved these changes

Assignees

@dosas dosas

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dosas @sambible @Griffin-Sullivan @omkarkhatavkar @ogajduse @ColeHiggins2