Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Leapp tests to single test and Refactor it #15571

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Merge Leapp tests to single test and Refactor it #15571

merged 1 commit into from
Sep 16, 2024

Conversation

shweta83
Copy link
Contributor

@shweta83 shweta83 commented Jul 3, 2024 •
edited
Loading

Problem Statement

  1. The module for leapp testing had different tests for testing with admin and non-admin permissions which can be merged into one.
  2. When we run multiple tests(or single parameterized test), all_repos list returns empty with previous implementation which creates content view without repos.

Solution

  1. Merge the tests for admin and non-admin to single test.
  2. Fetch the repo ids and update all_repos list so that content view will have all the repos.

Related Issues

@shweta83 shweta83 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jul 3, 2024
@shweta83 shweta83 self-assigned this Jul 3, 2024
@shweta83 shweta83 requested a review from a team as a code owner July 3, 2024 21:53
@shweta83 shweta83 marked this pull request as draft July 3, 2024 21:53
@shweta83
Copy link
Contributor Author

shweta83 commented Jul 3, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py -k test_leapp_upgrade_rhel

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7638
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py  -k test_leapp_upgrade_rhel --external-logging
Test Result : ================= 2 passed, 202 warnings in 4642.07s (1:17:22) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 3, 2024
@shweta83 shweta83 marked this pull request as ready for review July 4, 2024 06:00
vijaysawant
vijaysawant requested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic to fetch repo id can be written once outside if..else..

tests/foreman/cli/test_leapp_client.py Outdated Show resolved Hide resolved
@shweta83 shweta83 force-pushed the merge_and_refactor_leapp_tests branch from 376c67f to 84b1d59 Compare July 19, 2024 07:36
@shweta83 shweta83 requested a review from a team as a code owner July 19, 2024 07:36
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py -k test_leapp_upgrade_rhel

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 19, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7789
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py -k test_leapp_upgrade_rhel --external-logging
Test Result : ================= 186 warnings, 2 errors in 3079.38s (0:51:19) =================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jul 19, 2024
vijaysawant
vijaysawant reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shweta83 can you please try this changes?

tests/foreman/cli/test_leapp_client.py Outdated Show resolved Hide resolved
@shweta83 shweta83 force-pushed the merge_and_refactor_leapp_tests branch from 84b1d59 to 5288321 Compare August 22, 2024 09:57
@jyejare jyejare added the 6.16.z label Aug 22, 2024
@shweta83 shweta83 force-pushed the merge_and_refactor_leapp_tests branch 3 times, most recently from 1609b83 to 83aa689 Compare August 25, 2024 19:00
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py -k test_leapp_upgrade_rhel[admin-8.10_to_9.4]

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8652
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py -k test_leapp_upgrade_rhel --external-logging
Test Result : =================== 7 warnings, 2 errors in 64.02s (0:01:04) ===================

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8658
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py -k test_leapp_upgrade_rhel --external-logging
Test Result : ======================== 7 warnings, 2 errors in 53.66s ========================

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8660
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py -k test_leapp_upgrade_rhel --external-logging
Test Result : ======================== 7 warnings, 2 errors in 53.10s ========================

@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py -k test_leapp_upgrade_rhel
network_type: ipv4
env:
ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.16.0'
ROBOTTELO_server__deploy_arguments__deploy_snap_version: '4.0'
ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '8'

@shweta83
Copy link
Contributor Author

shweta83 commented Sep 16, 2024 •
edited
Loading 

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py -k test_leapp_upgrade_rhel
network_type: ipv4
env:
  ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.16.0'
  ROBOTTELO_server__deploy_arguments__deploy_snap_version: '4.0'
  ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '8'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8661
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py -k test_leapp_upgrade_rhel --external-logging
Test Result : ================= 2 passed, 173 warnings in 4517.04s (1:15:17) =================

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Sep 16, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit 2eef4c0 into SatelliteQE:master Sep 16, 2024
11 checks passed
This was referenced Sep 16, 2024
Closed
Closed
Closed
Closed
shweta83 added a commit to shweta83/robottelo that referenced this pull request Sep 16, 2024
@shweta83
Merge Leapp tests to single test and Refactor it (SatelliteQE#15571)
bda969c
@shweta83 shweta83 mentioned this pull request Sep 16, 2024
Merged
Gauravtalreja1 pushed a commit that referenced this pull request Sep 16, 2024
@shweta83
Merge Leapp tests to single test and Refactor it (#15571) (#16369)
054ec6b
shweta83 added a commit to shweta83/robottelo that referenced this pull request Sep 17, 2024
@shweta83
Merge Leapp tests to single test and Refactor it (SatelliteQE#15571)
e36b1da
@shweta83 shweta83 mentioned this pull request Sep 17, 2024
Draft
shweta83 added a commit to shweta83/robottelo that referenced this pull request Sep 17, 2024
@shweta83
Merge Leapp tests to single test and Refactor it (SatelliteQE#15571)
325d9fe
shweta83 added a commit to shweta83/robottelo that referenced this pull request Sep 17, 2024
@shweta83
Merge Leapp tests to single test and Refactor it (SatelliteQE#15571)
b1741ed
shweta83 added a commit to shweta83/robottelo that referenced this pull request Sep 17, 2024
@shweta83
Merge Leapp tests to single test and Refactor it (SatelliteQE#15571)
572d599
shweta83 added a commit to shweta83/robottelo that referenced this pull request Sep 17, 2024
@shweta83
Merge Leapp tests to single test and Refactor it (SatelliteQE#15571)
4a17f1e
shweta83 added a commit to shweta83/robottelo that referenced this pull request Sep 17, 2024
@shweta83
Merge Leapp tests to single test and Refactor it (SatelliteQE#15571)
75cd690
shweta83 added a commit to shweta83/robottelo that referenced this pull request Sep 17, 2024
@shweta83
Merge Leapp tests to single test and Refactor it (SatelliteQE#15571)
1cd5d6a
@shweta83 shweta83 mentioned this pull request Sep 17, 2024
Draft
shweta83 added a commit to shweta83/robottelo that referenced this pull request Sep 17, 2024
@shweta83
Merge Leapp tests to single test and Refactor it (SatelliteQE#15571)
1e0e1f1
shweta83 added a commit to shweta83/robottelo that referenced this pull request Sep 17, 2024
@shweta83
Merge Leapp tests to single test and Refactor it (SatelliteQE#15571)
a698ddd
@shweta83 shweta83 mentioned this pull request Sep 17, 2024
Draft
@Gauravtalreja1 Gauravtalreja1 mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sambible sambible sambible left review comments

@jameerpathan111 jameerpathan111 jameerpathan111 left review comments

@ogajduse ogajduse ogajduse approved these changes

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@vijaysawant vijaysawant vijaysawant approved these changes

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

Assignees

@shweta83 shweta83

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@shweta83 @Satellite-QE @sambible @ogajduse @jameerpathan111 @Gauravtalreja1 @vijaysawant @shubhamsg199 @jyejare