Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Validate if response is array before checking array key #33

Merged
merged 1 commit into from
Oct 4, 2021
Merged

[Fix] Validate if response is array before checking array key #33

merged 1 commit into from
Oct 4, 2021

Conversation

dnwjn
Copy link
Contributor

@dnwjn dnwjn commented Sep 20, 2021

This is a fix for the following error:

PHP Fatal error:  Uncaught TypeError: array_key_exists(): Argument #2 ($array) must be of type array, WP_Error given in <redacted>/wordpress/current/wp-content/plugins/warpdrive/src/class-api-response.php:50

joverthegrey
joverthegrey approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@joverthegrey joverthegrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joverthegrey joverthegrey merged commit 9ce98f7 into Savvii:master Oct 4, 2021
@dnwjn dnwjn deleted the fix/response-body branch October 4, 2021 15:09
@dnwjn dnwjn mentioned this pull request Oct 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joverthegrey joverthegrey joverthegrey approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnwjn @joverthegrey