Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temp fix for engine bug #181

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Temp fix for engine bug #181

merged 1 commit into from
Jul 5, 2023

Conversation

zhiyan114
Copy link
Collaborator

@zhiyan114 zhiyan114 commented Jul 5, 2023 •
edited
Loading

Fixes #180

This PR fixes a crash issue that is caused by NodeJS Engine bug.

@zhiyan114 zhiyan114 requested a review from Sayrix July 5, 2023 00:14
@zhiyan114 zhiyan114 added this to the 3.1.0 milestone Jul 5, 2023
Sayrix
Sayrix approved these changes Jul 5, 2023
View reviewed changes
Copy link
Owner

@Sayrix Sayrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested but seems good to me

@Sayrix Sayrix merged commit 8e22711 into main Jul 5, 2023
3 checks passed
@Sayrix Sayrix deleted the bugfix branch July 5, 2023 13:06
@zhiyan114 zhiyan114 mentioned this pull request Jul 18, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sayrix Sayrix Sayrix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

Bot throws error after running it for a period of time
2 participants
@zhiyan114 @Sayrix