Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Feature Updates #314

Merged
merged 18 commits into from
Feb 16, 2024
Merged

Some Feature Updates #314

merged 18 commits into from
Feb 16, 2024

Conversation

zhiyan114
Copy link
Collaborator

@zhiyan114 zhiyan114 commented Dec 31, 2023

Resolves #230

  • @camfsd are you able to give a try and see if the feat works as intended.

Test Note:

  • ticketTypes should now have staffRoles as array (though it can be undefined or empty array if not in use). Confirm with the example config if needed.
  • rolesWhoHaveAccessToTheTickets is now a "global access" role

Resolves #248

  • @RaiRaii I would still recommend you to use add commands instead, but in-case you want to mass add users (which does have a couple optimizations), you can use the new massadd command. Also do test it to confirm if it's working or not.

Test Note:

  • It's a standard slash command: massadd
    • It takes in a string argument (which removes the build-in user validation by discord).
    • User ID will be used as input
    • To add multiple users, use the comma , as the separator

Resolves #323
Unable to reproduce the said issue, perhaps the fix is already in this branch?


Unrelated

  • Added clearDM command to allow users to clean-up history DMs from the bot

@zhiyan114 zhiyan114 self-assigned this Dec 31, 2023
@zhiyan114 zhiyan114 added this to the 3.3.1 milestone Dec 31, 2023
@zhiyan114
Copy link
Collaborator Author

@camfsd @RaiRaii Let me know how the software is going before I start the merging process.

@zhiyan114 zhiyan114 marked this pull request as ready for review February 15, 2024 20:46
@Sayrix
Copy link
Owner

Sayrix commented Feb 15, 2024

Can you delete the package-lock.json just to see if after that the license compliance passes

@zhiyan114
Copy link
Collaborator Author

zhiyan114 commented Feb 15, 2024

In that case, then it has to be one of the sub-dependencies that's causing the issue.

Copy link
Owner

@Sayrix Sayrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just some copyrights who are still in 2023 (massadd.ts for example)

@Sayrix
Copy link
Owner

Sayrix commented Feb 16, 2024

Lmk if you want to push the version btw

@zhiyan114
Copy link
Collaborator Author

Alr, we'll prob do it after we organize with the new translation feature.

@zhiyan114 zhiyan114 merged commit a2712af into main Feb 16, 2024
3 checks passed
@zhiyan114 zhiyan114 deleted the feat branch February 16, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants