Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Maintenance #385

Merged
merged 5 commits into from
Jul 21, 2024
Merged

General Maintenance #385

merged 5 commits into from
Jul 21, 2024

Conversation

zhiyan114
Copy link
Collaborator

@zhiyan114 zhiyan114 requested a review from Sayrix as a code owner July 21, 2024 20:43
@zhiyan114 zhiyan114 marked this pull request as draft July 21, 2024 20:47
Copy link
Owner

@Sayrix Sayrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhiyan114
Copy link
Collaborator Author

Just need to check a couple more things on why TSC is yelling at nothing

@Sayrix
Copy link
Owner

Sayrix commented Jul 21, 2024

You can't transpile ?

@zhiyan114
Copy link
Collaborator Author

zhiyan114 commented Jul 21, 2024

Ye type check is complaining about a non-existing errors on @node/type after upgrading the package. One of the users did complain about this, but I thought that was just some installation error, but turns out, it's not...

@zhiyan114
Copy link
Collaborator Author

Just tested and it looks like it could be a typescript engine error, we'll just keep the older version for now

@zhiyan114 zhiyan114 marked this pull request as ready for review July 21, 2024 21:11
@Sayrix
Copy link
Owner

Sayrix commented Jul 21, 2024

Is there any open issue on typescript's github about that?

@zhiyan114 zhiyan114 merged commit c327f5d into main Jul 21, 2024
4 checks passed
@zhiyan114 zhiyan114 deleted the patch branch July 21, 2024 21:14
@zhiyan114
Copy link
Collaborator Author

I couldn't find any tbh, this feels like an edge case where it reproduceable on certain repo but not others.

I tested on my other bot project, and I got a completely different non-existing errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ticket permissions resetted when ticket parent change
2 participants