Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Github Enterprise #126

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Conversation

yeikel
Copy link
Contributor

@yeikel yeikel commented Feb 11, 2023

Closes #125

@yeikel yeikel requested a review from a team as a code owner February 11, 2023 00:15
@yeikel yeikel force-pushed the fix/GHE branch 5 times, most recently from 3b62b92 to 1fa10c1 Compare February 11, 2023 01:42
@ghaiszaher
Copy link
Member

@yeikel for some reason this doesn't work, I also tried it in another branch and in a private repository, I always get Error: Not Found. E.g. this current PR or this one: #127

Did you try it with an enterprise base URL?

@yeikel
Copy link
Contributor Author

yeikel commented Feb 11, 2023

@yeikel for some reason this doesn't work, I also tried it in another branch and in a private repository, I always get Error: Not Found. E.g. this current PR or this one: #127

Did you try it with an enterprise base URL?

That's strange. In my experience 404 errors in Github tend to be about lack of permissions but in this scenario it could be something else

Yes, I tested it in a private instance of GHE and it is working as expected

@yeikel
Copy link
Contributor Author

yeikel commented Feb 11, 2023

Can we try adding debug logs to see what is the url is trying in your test?

See : https://actions-cool.github.io/octokit-rest/guide/12_debug/

@yeikel yeikel force-pushed the fix/GHE branch 3 times, most recently from 95e7c81 to a346d94 Compare February 11, 2023 23:20
@yeikel
Copy link
Contributor Author

yeikel commented Feb 11, 2023

I tested the latest conditional logic pushed with 56ed3ba both with Github.com: https://github.com/yeikel/action-surefire-report/actions/runs/4153632808/jobs/7185381214 and with a private instance of GHE

I am not entirely sure why setting the github.com API URL directly results in authentication errors but it should be OK to proceed with this for now.

ghaiszaher
ghaiszaher previously approved these changes Feb 12, 2023
Copy link
Member

@ghaiszaher ghaiszaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

README.md Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
Co-authored-by: Ghais Zaher <ghaiszaher@gmail.com>
Co-authored-by: Ghais Zaher <ghaiszaher@gmail.com>
@yeikel
Copy link
Contributor Author

yeikel commented Feb 12, 2023

Thanks for fixing!

Thank you for reviewing. Please let me know if you have any additional feedback 🚀

@ghaiszaher ghaiszaher merged commit 4cbb611 into ScaCap:master Feb 16, 2023
@yeikel yeikel deleted the fix/GHE branch February 28, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Github Enterprise
4 participants