Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid huge input lookup errors #144

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Avoid huge input lookup errors #144

merged 1 commit into from
Mar 10, 2023

Conversation

nineinchnick
Copy link
Contributor

@nineinchnick nineinchnick commented Mar 10, 2023 •
edited by ghaiszaher
Loading

What

When parsing multiple large XML reports, it sometimes fails with the Huge input lookup error coming from the underlying XML parsing library. We have to explicitly allow parsing large files.

Run scacap/action-surefire-report@v1.6.0
  with:
    fail_if_no_tests: false
    commit: e191cb9c998956574c4c401f734f9596[2](https://github.com/trinodb/trino/actions/runs/4382083337/jobs/7670771144#step:4:2)120f[4](https://github.com/trinodb/trino/actions/runs/4382083337/jobs/7670771144#step:4:4)92
    github_token: ***
    report_paths: **/surefire-reports/TEST-*.xml, **/failsafe-reports/TEST-*.xml
    create_check: true
    check_name: Test Report
    fail_on_test_failures: false
    skip_publishing: false
    file_name_in_stack_trace: false
Going to parse results form **/surefire-reports/TEST-*.xml
 **/failsafe-reports/TEST-*.xml
Error: internal error: Huge input lookup

Fixes #145

How

Add the {huge: true} option to libxmljs.parsexml() call.

Ref: libxmljs/libxmljs#372

@nineinchnick nineinchnick requested a review from a team as a code owner March 10, 2023 10:45
@nineinchnick nineinchnick mentioned this pull request Mar 10, 2023
Merged
@ghaiszaher ghaiszaher mentioned this pull request Mar 10, 2023
Closed
@ghaiszaher ghaiszaher merged commit 7263a78 into ScaCap:master Mar 10, 2023
nineinchnick added a commit to nineinchnick/action-surefire-report that referenced this pull request Mar 13, 2023
@nineinchnick
Revert "Avoid huge input lookup errors (ScaCap#144)"
3cfa17d 
This reverts commit 7263a78.
@nineinchnick nineinchnick mentioned this pull request Mar 13, 2023
Merged
ghaiszaher pushed a commit that referenced this pull request Mar 13, 2023
@nineinchnick
Revert libxml (#147)
4845216 
* Revert "Run the action in a container (#141)"

This reverts commit 01b2782.

* Revert "Avoid huge input lookup errors (#144)"

This reverts commit 7263a78.

* Revert "Use a more efficient xml parser library (#138)"

This reverts commit 5b7a533.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sutil-dyego sutil-dyego sutil-dyego approved these changes

@ghaiszaher ghaiszaher ghaiszaher approved these changes

@crypticmind crypticmind Awaiting requested review from crypticmind

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: internal error: Huge input lookup
3 participants
@nineinchnick @ghaiszaher @sutil-dyego