Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use package to determine path #61

Merged
merged 8 commits into from
Feb 27, 2023
Merged

Use package to determine path #61

merged 8 commits into from
Feb 27, 2023

Conversation

QuietBird
Copy link
Contributor

Problem: If you have two classes with the same name, but in different packages, results of tests are shown for the first one found

@jmisur
Copy link
Contributor

jmisur commented May 31, 2021

Thanks for the PR. I will take a look at this shortly.

@ghaiszaher ghaiszaher closed this Dec 23, 2022
@ghaiszaher ghaiszaher reopened this Dec 23, 2022
@ghaiszaher ghaiszaher self-requested a review December 25, 2022 13:31
@yeikel
Copy link
Contributor

yeikel commented Feb 13, 2023

@ghaiszaher Do you think we can take a look at this one? This is a must in most projects

@ghaiszaher
Copy link
Member

@ghaiszaher Do you think we can take a look at this one? This is a must in most projects

@yeikel sure, I was planning to look into it but didn't have time yet.

@QuietBird it's a bit too old, but do you think you can come back to this PR and resolve the conflicts? Otherwise we can raise a separate PR.

…ge-to-determine-path

# Conflicts:
#	utils.js
@ghaiszaher ghaiszaher requested a review from a team as a code owner February 26, 2023 14:44
@ghaiszaher
Copy link
Member

ghaiszaher commented Feb 26, 2023

@ghaiszaher Do you think we can take a look at this one? This is a must in most projects

@yeikel sure, I was planning to look into it but didn't have time yet.

@QuietBird it's a bit too old, but do you think you can come back to this PR and resolve the conflicts? Otherwise we can raise a separate PR.

I pushed to this branch by accident and figured that I have access to do so. Ready for review now, tested here: #134

ghaiszaher
ghaiszaher previously approved these changes Feb 26, 2023
@ghaiszaher ghaiszaher merged commit a2d14ba into ScaCap:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants