Add minimized pixi.js test case #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgirault
force-pushed
the
pixi.js
branch
2 times, most recently
from
3dc9719 to
a024ea6
Compare
lgirault
changed the title
lgirault
changed the title
|
Sorry, I've been busy. thanks a lot for the repro! I'll try to get it to it soon :) |
|
no worries ! I tried to look into it, but the compiler code is a bit hairy 😅 |
|
hah it is, unfortunately! I tried to follow the Make It Work Make It Right Make It Fast rule, but even making it work is already pushing my limits. Especially this code with resolving modules :D I force pushed the branch with a fix now, will merge on green build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test case concerning this issue: #471