Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop circleci for github actions, run CI on mac and windows as well #500

Merged
merged 6 commits into from
Nov 15, 2022

Conversation

oyvindberg
Copy link
Collaborator

No description provided.

@oyvindberg
Copy link
Collaborator Author

todo:

  • fix windows tests. looks like line endings
  • make all three targets correctly cache test artifacts
  • start testing release-snapshot

@oyvindberg oyvindberg changed the title github actions, run CI on three OS drop circleci for github actions, run CI on mac and windows as well Nov 14, 2022
@oyvindberg oyvindberg force-pushed the github-actions branch 7 times, most recently from a50da7e to 3f0c1e3 Compare November 15, 2022 00:39
this allows us to pick the whitespace-insensitive digesting. Hopefully this will negate platform newline differences
@oyvindberg oyvindberg force-pushed the github-actions branch 5 times, most recently from c0dab1f to 9f3f95e Compare November 15, 2022 03:37
- ignore whitespace and blank lines when diffing (matches digesting logic)
- need to replace '\r\n' with '\n' some places because ST normalized newlines
- need to compare diffs without newlines and whitespace (matches digest logic)
@oyvindberg oyvindberg merged commit a829a36 into master Nov 15, 2022
@oyvindberg oyvindberg deleted the github-actions branch November 15, 2022 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant