Support export all types #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steinybot
commented
Dec 7, 2023
|
|
||
| val exporteeTree: Parser[Boolean ~ TsExportee.Tree] = | ||
| success(false) ~ (tsDecl ^^ TsExportee.Tree) | ||
|
|
||
| exporteeTree | exportedNames | exporteeStar | ||
| exporteeTree | exporteeStar | exportedNames |
There was a problem hiding this comment.
I had to swap this to get it to work. I think exportNames was failing fatally and not allowing back tracking.
steinybot
force-pushed
the
bug/export-all-types
branch
from
30dafca to
3a49a19
Compare
|
Thanks, I think this looks good! I'm gone on a trip all weekend, will test and merge next week 👍 |
|
@oyvindberg We need this fix for our project. Can you release the new version? |
|
Sorry this took so long @nghuuphuoc . beta44 is out now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #585