refactor: remove username and password, add axios instance into APICo…

…nfigurationParameters
ScaleLeap · Mar 9, 2021 · 51d4a46 · 51d4a46
1 parent a67acba
commit 51d4a46
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 14 deletions.
diff --git a/src/clients/uploads-api-client.ts b/src/clients/uploads-api-client.ts
@@ -7,13 +7,13 @@ import { isJsonMime } from '../helpers/is-json-mime'
 import { APIConfigurationParameters } from '../types/api-configuration-parameters'
 
 export class UploadsApiClient extends UploadsApi {
-  constructor(parameters?: APIConfigurationParameters, axios?: AxiosInstance) {
+  constructor(parameters?: APIConfigurationParameters) {
     const { sellingPartner } = amazonMarketplaces.US
     const basePath: string = sellingPartner ? sellingPartner.region.endpoint : ''
     let axiosInstance: AxiosInstance
 
-    if (axios) {
-      axiosInstance = axios
+    if (parameters && parameters.axios) {
+      axiosInstance = parameters.axios
     } else {
       axiosInstance = globalAxios.create()
       axiosInstance.interceptors.response.use(

diff --git a/src/types/api-configuration-parameters.ts b/src/types/api-configuration-parameters.ts
@@ -1,4 +1,4 @@
-import { AxiosRequestConfig } from 'axios'
+import { AxiosInstance, AxiosRequestConfig } from 'axios'
 
 export interface APIConfigurationParameters {
   /**
@@ -11,20 +11,15 @@ export interface APIConfigurationParameters {
     | Promise<string>
     | ((name: string) => string)
     | ((name: string) => Promise<string>)
+
   /**
-   * parameter for basic security
-   *
-   * @type {string}
-   * @memberof APIConfigurationParameters
-   */
-  username?: string
-  /**
-   * parameter for basic security
+   * Axios Instance
    *
-   * @type {string}
+   * @type {AxiosInstance}
    * @memberof APIConfigurationParameters
    */
-  password?: string
+  axios?: AxiosInstance
+
   /**
    * parameter for oauth2 security
    * @param name security name