fix: change rate limit value as a number

ScaleLeap · May 19, 2021 · c994ef4 · c994ef4
1 parent 540abee
commit c994ef4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/types/errors/selling-partner-api-errors.ts b/src/types/errors/selling-partner-api-errors.ts
@@ -47,11 +47,14 @@ export class SellingPartnerNotFoundError extends SellingPartnerGenericError {}
 export class SellingPartnerRequestTooLongError extends SellingPartnerGenericError {}
 export class SellingPartnerUnsupportedMediaTypeError extends SellingPartnerGenericError {}
 export class SellingPartnerTooManyRequestsError extends SellingPartnerGenericError {
-  public rateLimit?: string
+  public rateLimit?: number
 
   public constructor(error: ModelError, headers: Headers) {
     super(error, headers)
-    this.rateLimit = headers['x-amzn-RateLimit-Limit'] || headers['x-amzn-ratelimit-limit']
+    this.rateLimit =
+      Number(headers['x-amzn-RateLimit-Limit']) ||
+      Number(headers['x-amzn-ratelimit-limit']) ||
+      undefined
   }
 }
 export class SellingPartnerInternalServerError extends SellingPartnerGenericError {}

diff --git a/test/types/errors/errors.test.ts b/test/types/errors/errors.test.ts
@@ -4,6 +4,7 @@ import {
 } from '@scaleleap/amazon-marketplaces'
 import { jestPollyContext } from '@scaleleap/jest-polly'
 import { StatusCodes } from 'http-status-codes'
+import { toNumber } from 'lodash'
 
 import {
   APIConfigurationParameters,
@@ -112,7 +113,7 @@ describe(`client`, () => {
     )
     await expect(client.getMarketplaceParticipations()).rejects.toHaveProperty(
       'rateLimit',
-      defaultRateLimit,
+      toNumber(defaultRateLimit),
     )
   })
 })