Merge pull request #211 from SceneGate/feature/fix-lazyfile-initialpos

🐛 Fix Position getter of uninitiliazed LazyFileStream returning 0

.editorconfig

@@ -239,6 +239,7 @@ dotnet_naming_symbols.non_field_members.required_modifiers =
 ### .NET SDK
 dotnet_diagnostic.CA1303.severity = none # We don't translate exception and log messages from English
 dotnet_diagnostic.SA1025.severity = none # Allow spaces in comments to structure info
+dotnet_diagnostic.IDE0028.severity = suggestion # Simplify collection initialization
 dotnet_diagnostic.IDE0045.severity = suggestion # Simplify ifs
 dotnet_diagnostic.IDE0046.severity = suggestion # Simplify ifs
 

.github/workflows/build-and-release.yml

@@ -15,7 +15,7 @@ jobs:
     name: "Build"
     uses: ./.github/workflows/build.yml
     with:
-      dotnet_version: '8.0.100'
+      dotnet_version: '8.0.303'
 
   # Preview release on push to main only
   # Stable release on version tag push only
@@ -25,7 +25,7 @@ jobs:
     needs: build
     uses: ./.github/workflows/deploy.yml
     with:
-      dotnet_version: '8.0.100'
+      dotnet_version: '8.0.303'
       azure_nuget_feed: 'https://pkgs.dev.azure.com/SceneGate/SceneGate/_packaging/SceneGate-Preview/nuget/v3/index.json'
     secrets:
       nuget_preview_token: "az" # Dummy values as we use Azure DevOps only

.github/workflows/build.yml

@@ -29,6 +29,11 @@ jobs:
         with:
           dotnet-version: ${{ inputs.dotnet_version }}
 
+      - name: "Setup .NET 6.0 SDK"
+        uses: actions/setup-dotnet@v3
+        with:
+          dotnet-version: '6.0.424'
+
       - name: "Build and test"
         run: dotnet run --project build/orchestrator -- --target=Default --dotnet-configuration=Release
         env:

src/Yarhl.UnitTests/IO/StreamFormat/LazyFileStreamTests.cs

@@ -69,10 +69,29 @@ public void ConstructorSetFileLengthOrZero()
         }
 
         [Test]
-        public void GetPositionWithoutInitializeReturnsZero()
+        public void GetPositionWithoutInitializeReturnsSameAsSet()
         {
             using var stream = new LazyFileStream(tempFile, FileOpenMode.ReadWrite);
             Assert.That(stream.Position, Is.EqualTo(0));
+
+            stream.Position = 0x42;
+            Assert.That(stream.BaseStream, Is.Null);
+            Assert.That(stream.Position, Is.EqualTo(0x42));
+        }
+
+        [Test]
+        public void FileOpenedWithInitialPosition()
+        {
+            byte[] fileContent = { 0xFF, 0x42 };
+            File.WriteAllBytes(tempFile, fileContent);
+            using var stream = new LazyFileStream(tempFile, FileOpenMode.ReadWrite);
+            stream.Position = 1;
+
+            Assert.That(stream.BaseStream, Is.Null);
+            byte actual = (byte)stream.ReadByte();
+
+            Assert.That(actual, Is.EqualTo(fileContent[1]));
+            Assert.That(stream.Position, Is.EqualTo(2));
         }
 
         [Test]

src/Yarhl/IO/StreamFormat/LazyFileStream.cs

@@ -62,7 +62,7 @@ public LazyFileStream(string path, FileOpenMode mode)
         /// <inheritdoc/>
         public override long Position
         {
-            get => BaseStream?.Position ?? 0;
+            get => BaseStream?.Position ?? initialPosition;
             set
             {
                 if (BaseStream is null) {