-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mypy schema: Support show_error_codes
, show_error_code_links
#3467
Comments
|
Ah, so they're both undocumented and one is deprecated. For a while this project has not allowed including undocumented features, but I've been moving towards the opposite direction. More info at #3372, but long story short, it improves the experience when the JSON Schema doesn't show an error for something that is actually accepted by the tool (even if deprecated or undocumented). As a result, we no longer require all properties to be documented :) So I think it would be best to change the schema so that these errors are fixed. At a minimum, the properties can be added, and their descriptions can at least include "UNDOCUMENTED" or "DEPRECATED". I added a little documentation here, but I think it's kind of hidden |
What about adding schemastore/src/schemas/json/ruff.json Line 762 in 734c0e5
|
That could be added too - as far as I know, it is not a violation of the specification to include "unknown properties" (like "deprecated" for draft-07) in the schema. I didn't mention it at first because it is excluded in draft-07 - because of this, I think json schema parsers would ignore it and the end user would have no way of knowing it is deprecated (unless it is in |
Area with issue?
JSON Schema
✔️ Expected Behavior
Properties on the mypy such as
show_error_codes
andshow_error_code_links
are used, the schema should work.❌ Actual Behavior
An error is raised: additional properties are not allowed
More info here
YAML or JSON file that does not work.
mypy.json
IDE or code editor.
None
Are you making a PR for this?
No, someone else must create the PR.
The text was updated successfully, but these errors were encountered: