Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy: support 'no_implicit_optional', 'no_implicit_reexport' #3470

Closed
mishamsk opened this issue Dec 21, 2023 · 1 comment · Fixed by #3471
Closed

mypy: support 'no_implicit_optional', 'no_implicit_reexport' #3470

mishamsk opened this issue Dec 21, 2023 · 1 comment · Fixed by #3471
Labels
issue:bug Report errors or unexpected behavior (auto-generated by issue forms)

Comments

@mishamsk
Copy link
Contributor

Area with issue?

JSON Schema

✔️ Expected Behavior

Support both 'no_implicit_optional' and 'no_implicit_reexport', both of which are valid and documented (see doc)

❌ Actual Behavior

In vs code (via Even Better TOML extension):

Additional properties are not allowed ('no_implicit_optional', 'no_implicit_reexport' were unexpected)Even Better TOML
Additional properties are not allowed ('no_implicit_optional', 'no_implicit_reexport' were unexpected)Even Better TOML

YAML or JSON file that does not work.

[[tool.mypy.overrides]]
no_implicit_optional = true
no_implicit_reexport = true

IDE or code editor.

Visual Studio Code

Are you making a PR for this?

Yes, I will create a PR.

@mishamsk mishamsk added the issue:bug Report errors or unexpected behavior (auto-generated by issue forms) label Dec 21, 2023
@hyperupcall
Copy link
Member

Related to #3467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue:bug Report errors or unexpected behavior (auto-generated by issue forms)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants