Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix margin and padding in block.json #1903

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

ajlende
Copy link
Contributor

@ajlende ajlende commented Oct 25, 2021

Merged enums in margin and padding since they can be used together according to WordPress/gutenberg#31774

Merged enums in margin and padding since they can be used together according to WordPress/gutenberg#31774
Copy link
Contributor

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajlende As far as I understand it from the handbook it can either be

  • boolean
  • any combination of: top left right bottom
  • any combination of: horizontal vertical

The change you made would not throw an error when top and vertical are mixed

That is at least based on the documentation here: https://developer.wordpress.org/block-editor/reference-guides/block-api/block-supports/#spacing

Copy link
Contributor

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (y)

@madskristensen madskristensen merged commit bb8a1e3 into SchemaStore:master Oct 25, 2021
@madskristensen
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants