Fix tests in advance of next ggplot2 release #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelly-sovacool
requested review from
a team and
courtneyarmour
and removed request for
a team
courtneyarmour
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Change(s) made
theme_*functions to prevent test failures anticipated with ggplot2 v3.4.0. They now directly test the elements changed by our custom themes, instead of the entire theme object. This should make the tests more robust to any future changes in the ggplot2 API.tidyverse/ggplot2@v3.4.0-rc. Their unit tests also fail with the same problem, so I'm confident it'll be fixed before the release.Checklist
(
Strikethroughany points that are not applicable.)[ ] Write unit tests for any new functionality.[ ] Update roxygen comments & vignettes if there are any API changes.[ ] UpdateNEWS.mdif this includes any user-facing changes.