Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for ggplot2 v3.4.0 & tidyselect v1.2.0 #44

Merged
merged 14 commits into from
Nov 9, 2022
Merged

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Nov 7, 2022

Change(s) made

  • Use linewidth instead of size for ggplot2 line-based geoms (switched in ggplot2 v3.4.0).
    • Thought I had previously fixed this, but I missed one in theme_lucas().
  • Don't use .data[[colname]] syntax anymore (deprecated in tidyselect v1.2.0). Use data variables or any_of(colname) depending on the context.

Checklist

(Strikethrough any points that are not applicable.)

  • [ ] Write unit tests for any new functionality.
  • [ ] Update roxygen comments & vignettes if there are any API changes.
  • [ ] Update NEWS.md if this includes any user-facing changes.
  • The check workflow succeeds on your most recent commit.

@kelly-sovacool kelly-sovacool requested review from a team and courtneyarmour and removed request for a team November 9, 2022 21:23
@kelly-sovacool kelly-sovacool marked this pull request as ready for review November 9, 2022 23:41
@kelly-sovacool kelly-sovacool merged commit cd04b11 into main Nov 9, 2022
@kelly-sovacool kelly-sovacool deleted the ggplot2-3.4.0 branch November 9, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants